Skip to content
This repository

field constructor template has been adjusted to bootstrap2 for .form-horizontal form class #217

Closed
wants to merge 1 commit into from

2 participants

Bijan Guillaume Bort
Bijan

Referring to this ticket I chose to update the form helper for bootstrap2-code.
https://play.lighthouseapp.com/projects/82401-play-20/tickets/248-support-bootstrap2x#ticket-248-2

In order to get comparable results to the bootstrap 1.4 code I chode the layout for the .form-horizontal class (see http://twitter.github.com/bootstrap/base-css.html#forms).

Guillaume Bort
Owner

Sorry, we rejected all pull requests about this. The twitter bootstrap helpers must be provided as a plugin.

Guillaume Bort guillaumebort closed this
Bijan

Makes sense. But then the outdated template helper should be dropped from master, right?

Guillaume Bort
Owner

@tschundeee Right, we will deprecate it in the next version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Showing 1 unique commit by 1 author.

Apr 01, 2012
Bijan field constructor template has been adjusted to bootstrap2 for .form-…
…horizontal form class
8f40a21
This page is out of date. Refresh to see the latest.
8  framework/src/play/src/main/scala/views/helper/twitterBootstrap/twitterBootstrapFieldConstructor.scala.html
@@ -7,11 +7,11 @@
7 7
 * Generate input according twitter bootsrap rules *
8 8
 **************************************************@
9 9
 
10  
-<div class="clearfix @elements.args.get('_class) @if(elements.hasErrors) {error}" id="@elements.args.get('_id).getOrElse(elements.id + "_field")">
11  
-    <label for="@elements.id">@elements.label(elements.lang)</label>
12  
-    <div class="input">
  10
+<div class="control-group @elements.args.get('_class) @if(elements.hasErrors) {error}" id="@elements.args.get('_id).getOrElse(elements.id + "_field")">
  11
+    <label class="control-label" for="@elements.id">@elements.label(elements.lang)</label>
  12
+    <div class="controls">
13 13
         @elements.input
14 14
         <span class="help-inline">@elements.errors(elements.lang).mkString(", ")</span>
15  
-        <span class="help-block">@elements.infos(elements.lang).mkString(", ")</span> 
  15
+        <p class="help-block">@elements.infos(elements.lang).mkString(", ")</p> 
16 16
     </div>
17 17
 </div>
Commit_comment_tip

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.