Fix compilation error of Java Promise.pure #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -116,8 +116,13 @@ public Promise(play.api.libs.concurrent.Promise<A> promise) { | |||
| * | |||
| * @param a the value for the promise | |||
| */ | |||
| public Promise(A a) { | |||
| this(play.api.libs.concurrent.Promise$.MODULE$.pure(a)); | |||
| public Promise(final A a) { | |||
There was a problem hiding this comment.
Hm, maybe we should make the parameter a lazy too? So it should have type Function0<A> instead of A.
pk11
pushed a commit
that referenced
this pull request
Apr 24, 2012
Fix compilation error of Java Promise.pure
|
Thanks Julien, I actually just wanted to pull in the small fix (fixing the runtime exception) but the other changeset was in the same branch :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last commit broke compilation. I didn’t test this code, I just made it compiling.