Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Play Asset JavaScript literal binder #3044

Merged
merged 2 commits into from Jun 24, 2014

Conversation

Projects
None yet
2 participants
@akkie
Copy link
Contributor

commented Jun 17, 2014

Without the proposed binder, Play doesn't compile the project with the message:

No JavaScript litteral binder found for type controllers.Assets.Asset. Try to implement an implicit JavascriptLitteral for this type.

when using the following route:

GET     /$file<(css|img|js)/.*>     controllers.CustomAssets.at(path="/public", file: Asset)
GET     /robots.txt                 controllers.CustomAssets.at(path="/public", file: Asset ="robots.txt")
GET     /favicon.ico                controllers.CustomAssets.at(path="/public", file: Asset ="img/favicon.ico")

It also fixes the spelling (litteral => literal)

See #3031

@akkie akkie changed the title Add Play Asset JavaScript litteral binder Add Play Asset JavaScript literal binder Jun 17, 2014

jroper added a commit that referenced this pull request Jun 24, 2014

Merge pull request #3044 from akkie/patch-4
Add Play Asset JavaScript literal binder

@jroper jroper merged commit 6fe5c1d into playframework:master Jun 24, 2014

1 check passed

default Merged build finished.
Details
@jroper

This comment has been minimized.

Copy link
Member

commented Jun 24, 2014

Backported the asset literal fix to 2.3.x: 4d8d9a7

@jroper jroper added this to the 2.3.1 milestone Jun 24, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.