Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix excessive reloading when fallback watcher is used instead of JNotify. #3057

Merged
merged 1 commit into from Jun 24, 2014

Conversation

Projects
None yet
2 participants
@shkhln
Copy link
Contributor

commented Jun 21, 2014

Restores pre- a0262e4 behavior. I have basically the same issue as an author of this thread. Could also be related to #3020.

@jroper

This comment has been minimized.

Copy link
Member

commented Jun 24, 2014

This sounds like it will fix a number of other issues that people have reported as well. Man this code in Play is messy and hard to follow.... thanks for finding this!

jroper added a commit that referenced this pull request Jun 24, 2014

Merge pull request #3057 from shkhln/reloading-fix
Fix excessive reloading when fallback watcher is used instead of JNotify.

@jroper jroper merged commit 18f7987 into playframework:master Jun 24, 2014

1 check passed

default Merged build finished.
Details

@jroper jroper added this to the 2.3.1 milestone Jun 24, 2014

@jroper

This comment has been minimized.

Copy link
Member

commented Jun 24, 2014

Backported to 2.3.x: e4ba701

@shkhln shkhln deleted the shkhln:reloading-fix branch Jul 1, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.