Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for sbt-web 1.1 #3227

Merged
merged 1 commit into from Jul 29, 2014

Conversation

Projects
None yet
2 participants
@pvlugter
Copy link
Contributor

commented Jul 29, 2014

Add support for using upcoming sbt-web 1.1 with play 2.3.

Filter out asset directories from the reloader classpath so that dev reloading does not do a full reload on asset changes. In sbt-web 1.1 multi-module builds there are extra class directories on the classpath, with the assets in webjar format, and these are marked with an attribute.

Add a switch for disabling the asset aggregation built into the play plugin.

@@ -159,6 +159,9 @@ trait PlaySettings {
// all user classes, in this project and any other subprojects that it depends on
playReloaderClasspath <<= Classpaths.concatDistinct(exportedProducts in Runtime, internalDependencyClasspath in Runtime),

// filter out asset directories from the classpath (supports sbt-web 1.0 and 1.1)
playReloaderClasspath ~= { _.filter(_.get(WebKeys.webModulesLib.key).isEmpty) },

This comment has been minimized.

Copy link
@jroper

jroper Jul 29, 2014

Member

Nice.

jroper added a commit that referenced this pull request Jul 29, 2014

@jroper jroper merged commit bba3a31 into playframework:2.3.x Jul 29, 2014

1 check passed

default Merged build finished.
Details

@pvlugter pvlugter deleted the pvlugter:update-sbt-web-2.3.x branch Jul 29, 2014

@jroper jroper added this to the 2.3.3 milestone Aug 12, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.