Lighthouse 453: Have the play script do a better check as to whether project is actually a play project #324

Closed
wants to merge 3 commits into from

2 participants

@benmccann

This is an alternative to pull request 323 (#323). Both are better than the current situation in my personal opinion. This actually checks whether the project is a play project. The current script does not do that and is not a great check since other sbt or even non-sbt projects may have an application.conf file. Also, as described in Lighthouse 453 you get into goofy situations right now where you need to place an empty application.conf, which seems rather silly.

@pk11 pk11 was assigned May 30, 2012
@pk11 pk11 added a commit that referenced this pull request May 30, 2012
@pk11 pk11 [#324 #323] add a check against `project` folder in play scripts
This will allow the play scripts to be used with ad-hoc project layouts where the root PlayProject (and therefore `conf/application.conf`) is missing. Defining a root project is still recommended though.
f8e95ce
@pk11 pk11 closed this May 30, 2012
@ornicar ornicar added a commit that referenced this pull request May 30, 2012
@ornicar ornicar Merge branch 'master' of git://github.com/playframework/Play20 into m…
…aster-tcp

* 'master' of git://github.com/playframework/Play20:
  [#324 #323] add a check against `project` folder in play scripts
  Fix for #472
  Ticket #476
9f8116f
@jroper jroper added a commit that referenced this pull request Sep 25, 2012
@jroper jroper [#324] Fixed bug in Router.queryString when handling empty strings fr…
…om QueryStringBindable
63a19ac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment