Lighthouse 453: Have the play script do a better check as to whether project is actually a play project #324

wants to merge 3 commits into


None yet
2 participants

benmccann commented May 18, 2012

This is an alternative to pull request 323 (playframework#323). Both are better than the current situation in my personal opinion. This actually checks whether the project is a play project. The current script does not do that and is not a great check since other sbt or even non-sbt projects may have an application.conf file. Also, as described in Lighthouse 453 you get into goofy situations right now where you need to place an empty application.conf, which seems rather silly.

@ghost ghost assigned pk11 May 30, 2012

pk11 added a commit that referenced this pull request May 30, 2012

[#324 #323] add a check against `project` folder in play scripts
This will allow the play scripts to be used with ad-hoc project layouts where the root PlayProject (and therefore `conf/application.conf`) is missing. Defining a root project is still recommended though.

@pk11 pk11 closed this May 30, 2012

jroper added a commit that referenced this pull request Sep 25, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment