Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add java.util.UUID JavaScript literal binder #3508

Merged
merged 1 commit into from Oct 21, 2014

Conversation

Projects
None yet
2 participants
@mkurz
Copy link
Member

commented Oct 15, 2014

Without the proposed binder, Play doesn't compile the project with the message:

No JavaScript literal binder found for type java.util.UUID. Try to implement an implicit JavascriptLiteral for this type.

when using one of the following routes:

GET /test1    controllers.Application.test(id: java.util.UUID = null)
# or 
GET /test2    controllers.Application.test(id: java.util.UUID = java.util.UUID.fromString("00000000-0000-0000-0000-000000000000"))

With the attached Fix these routes work fine now.

Please backport to 2.3.x like you did with #3044 (be aware to rename JavascriptLiteral to JavascriptLitteral for the 2.3.x branch).

@mkurz

This comment has been minimized.

Copy link
Member Author

commented Oct 15, 2014

After doing some more work I found out there are more JavaScript literal binders missing. I added them (and fixed some bugs) with PR #3514. Please backport to 2.3.x, thanks a lot!

jroper added a commit that referenced this pull request Oct 21, 2014

Merge pull request #3508 from mkurz/UUIDJavaScriptLiteralBinder
Add java.util.UUID JavaScript literal binder

@jroper jroper merged commit 4a01a12 into playframework:master Oct 21, 2014

1 check passed

default Merged build finished.
Details

@jroper jroper added this to the 2.3.6 milestone Oct 28, 2014

@mkurz mkurz deleted the mkurz:UUIDJavaScriptLiteralBinder branch Feb 17, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.