Pass Signpost an InputStream rather than null to avoid NPE #394

Merged
merged 1 commit into from Sep 6, 2012

Projects

None yet

4 participants

@dt
dt commented Jul 28, 2012

When signing a POST request constructed with WS.url(...).post(Map(...)), Play's WSRequestAdapter.getMessagePayload() returns null, causing signpost to throw an NPE: https://gist.github.com/3193633.

Demonstration code: https://gist.github.com/3193621

@bennettandrews

+1 on fixing this. I'm running into the same issues. getMessagePayload needs to return the posts body.

@pk11

@tinystatemachine could you please sign our CLA? http://www.typesafe.com/contribute/cla Thanks

@dt
@pk11 pk11 merged commit d07945e into playframework:master Sep 6, 2012
@drunkhacker

So is this merged in to 2.0.4? or should I checkout newest master branch?

@dt
dt commented Dec 30, 2012

Last I checked, it is not in 2.0.4.

It did make it into the 2.1-RC1 release, so I'm now using that.

@drunkhacker

Ok then I'll use 2.1 RC . Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment