Upgrade to Akka HTTP 1.0-M4 #4007

Merged
merged 9 commits into from Mar 4, 2015

Conversation

Projects
None yet
3 participants
@richdougherty
Member

richdougherty commented Mar 2, 2015

A few code changes were needed because of Akka API changes.

@benmccann

This comment has been minimized.

Show comment
Hide comment
@benmccann

benmccann Mar 2, 2015

Contributor

@richdougherty maybe this really is broken? it seemed unrelated but keeps failing in the same manner

Contributor

benmccann commented Mar 2, 2015

@richdougherty maybe this really is broken? it seemed unrelated but keeps failing in the same manner

@richdougherty

This comment has been minimized.

Show comment
Hide comment
@richdougherty

richdougherty Mar 2, 2015

Member

@benmccann, I think those errors are OK. They're logged during a test that checks error handling. It would be nicer if we didn't display the errors at all. Anyway, in this case I'm pretty sure the build failed due to a timeout in the scripted tests. I'll investigate further and see if I can get it working.

[info] ---- AKKA HTTP SERVER SCRIPTED TESTS
[info]
[info] Loading project definition from /scratch/jenkins/workspace/play-master-PRs/framework/project/project
[info] Loading project definition from /scratch/jenkins/workspace/play-master-PRs/framework/project
[info] Set current project to Root (in build file:/scratch/jenkins/workspace/play-master-PRs/framework/)
[info] Packaging /scratch/jenkins/workspace/play-master-PRs/framework/src/play-akka-http-server/target/scala-2.10/play-akka-http-server-experimental_2.10-2.4-SNAPSHOT-sources.jar ...
[info] Done packaging.
[info] Wrote /scratch/jenkins/workspace/play-master-PRs/framework/src/play-akka-http-server/target/scala-2.10/play-akka-http-server-experimental_2.10-2.4-SNAPSHOT.pom
[info] :: delivering :: com.typesafe.play#play-akka-http-server-experimental_2.10;2.4-SNAPSHOT :: 2.4-SNAPSHOT :: integration :: Sun Mar 01 22:22:39 EST 2015
[info]  delivering ivy file to /scratch/jenkins/workspace/play-master-PRs/framework/src/play-akka-http-server/target/scala-2.10/ivy-2.4-SNAPSHOT.xml
[info] Packaging /scratch/jenkins/workspace/play-master-PRs/framework/src/play-akka-http-server/target/scala-2.10/play-akka-http-server-experimental_2.10-2.4-SNAPSHOT.jar ...
[info] Done packaging.
[info]  published play-akka-http-server-experimental_2.10 to /home/jenkins/.ivy2/local/com.typesafe.play/play-akka-http-server-experimental_2.10/2.4-SNAPSHOT/poms/play-akka-http-server-experimental_2.10.pom
[info]  published play-akka-http-server-experimental_2.10 to /home/jenkins/.ivy2/local/com.typesafe.play/play-akka-http-server-experimental_2.10/2.4-SNAPSHOT/jars/play-akka-http-server-experimental_2.10.jar
[info]  published play-akka-http-server-experimental_2.10 to /home/jenkins/.ivy2/local/com.typesafe.play/play-akka-http-server-experimental_2.10/2.4-SNAPSHOT/srcs/play-akka-http-server-experimental_2.10-sources.jar
[info]  published ivy to /home/jenkins/.ivy2/local/com.typesafe.play/play-akka-http-server-experimental_2.10/2.4-SNAPSHOT/ivys/ivy.xml
Running akka-http / play-akka-http-plugin
Build timed out (after 76 minutes). Marking the build as aborted.
Member

richdougherty commented Mar 2, 2015

@benmccann, I think those errors are OK. They're logged during a test that checks error handling. It would be nicer if we didn't display the errors at all. Anyway, in this case I'm pretty sure the build failed due to a timeout in the scripted tests. I'll investigate further and see if I can get it working.

[info] ---- AKKA HTTP SERVER SCRIPTED TESTS
[info]
[info] Loading project definition from /scratch/jenkins/workspace/play-master-PRs/framework/project/project
[info] Loading project definition from /scratch/jenkins/workspace/play-master-PRs/framework/project
[info] Set current project to Root (in build file:/scratch/jenkins/workspace/play-master-PRs/framework/)
[info] Packaging /scratch/jenkins/workspace/play-master-PRs/framework/src/play-akka-http-server/target/scala-2.10/play-akka-http-server-experimental_2.10-2.4-SNAPSHOT-sources.jar ...
[info] Done packaging.
[info] Wrote /scratch/jenkins/workspace/play-master-PRs/framework/src/play-akka-http-server/target/scala-2.10/play-akka-http-server-experimental_2.10-2.4-SNAPSHOT.pom
[info] :: delivering :: com.typesafe.play#play-akka-http-server-experimental_2.10;2.4-SNAPSHOT :: 2.4-SNAPSHOT :: integration :: Sun Mar 01 22:22:39 EST 2015
[info]  delivering ivy file to /scratch/jenkins/workspace/play-master-PRs/framework/src/play-akka-http-server/target/scala-2.10/ivy-2.4-SNAPSHOT.xml
[info] Packaging /scratch/jenkins/workspace/play-master-PRs/framework/src/play-akka-http-server/target/scala-2.10/play-akka-http-server-experimental_2.10-2.4-SNAPSHOT.jar ...
[info] Done packaging.
[info]  published play-akka-http-server-experimental_2.10 to /home/jenkins/.ivy2/local/com.typesafe.play/play-akka-http-server-experimental_2.10/2.4-SNAPSHOT/poms/play-akka-http-server-experimental_2.10.pom
[info]  published play-akka-http-server-experimental_2.10 to /home/jenkins/.ivy2/local/com.typesafe.play/play-akka-http-server-experimental_2.10/2.4-SNAPSHOT/jars/play-akka-http-server-experimental_2.10.jar
[info]  published play-akka-http-server-experimental_2.10 to /home/jenkins/.ivy2/local/com.typesafe.play/play-akka-http-server-experimental_2.10/2.4-SNAPSHOT/srcs/play-akka-http-server-experimental_2.10-sources.jar
[info]  published ivy to /home/jenkins/.ivy2/local/com.typesafe.play/play-akka-http-server-experimental_2.10/2.4-SNAPSHOT/ivys/ivy.xml
Running akka-http / play-akka-http-plugin
Build timed out (after 76 minutes). Marking the build as aborted.

richdougherty added some commits Mar 2, 2015

Add timeouts to scripted test HTTP requests
Doing this should stop the build from stalling.
Fix to reenable testing of non-Netty servers
The ServerProvider test code now always uses an argument, if one is
provided, rather than always using the ServerProvider configured in
reference.conf. This change was needed because a ServerProvider
setting was recently added to reference.conf. Since then, the
ServerProvider test code has been accidentally using the configured
value instead of the value provided via an argument.
@richdougherty

This comment has been minimized.

Show comment
Hide comment
@richdougherty

richdougherty Mar 4, 2015

Member

Sorry, that code was seriously broken!

I wasn't even running Akka HTTP tests properly. The Akka HTTP tests were running using Netty; they'd broken during the DI test changes. So the Akka HTTP upgrade wasn't tested and didn't work at all. Luckily the scripted tests picked up the problem. (BTW I've fixed up the scripted tests so they shouldn't hang any more if they don't get a response from the server.)

Member

richdougherty commented Mar 4, 2015

Sorry, that code was seriously broken!

I wasn't even running Akka HTTP tests properly. The Akka HTTP tests were running using Netty; they'd broken during the DI test changes. So the Akka HTTP upgrade wasn't tested and didn't work at all. Luckily the scripted tests picked up the problem. (BTW I've fixed up the scripted tests so they shouldn't hang any more if they don't get a response from the server.)

@richdougherty

This comment has been minimized.

Show comment
Hide comment
@richdougherty

richdougherty Mar 4, 2015

Member

The Play-WS subproject is failing with security algorithm errors. These tests work locally for me. I wonder what's going on? @wsargent, do you have any suggestions?

[error]    NoSuchAlgorithmException: : unrecognized algorithm name: SHA256WithRSA  (AlgorithmId.java:407)
[error] sun.security.x509.AlgorithmId.get(AlgorithmId.java:407)
[error] sun.security.x509.X509CertImpl.sign(X509CertImpl.java:564)
[error] sun.security.x509.X509CertImpl.sign(X509CertImpl.java:528)
[error] play.api.libs.ws.ssl.CertificateGenerator$.generateCertificate(CertificateGenerator.scala:84)
[error] play.api.libs.ws.ssl.CertificateGenerator$.generateRSAWithSHA256(CertificateGenerator.scala:35)
[error] play.api.libs.ws.ssl.AlgorithmCheckerSpec$$anonfun$1$$anonfun$apply$4.apply(AlgorithmCheckerSpec.scala:32)
[error] play.api.libs.ws.ssl.AlgorithmCheckerSpec$$anonfun$1$$anonfun$apply$4.apply(AlgorithmCheckerSpec.scala:27)
Member

richdougherty commented Mar 4, 2015

The Play-WS subproject is failing with security algorithm errors. These tests work locally for me. I wonder what's going on? @wsargent, do you have any suggestions?

[error]    NoSuchAlgorithmException: : unrecognized algorithm name: SHA256WithRSA  (AlgorithmId.java:407)
[error] sun.security.x509.AlgorithmId.get(AlgorithmId.java:407)
[error] sun.security.x509.X509CertImpl.sign(X509CertImpl.java:564)
[error] sun.security.x509.X509CertImpl.sign(X509CertImpl.java:528)
[error] play.api.libs.ws.ssl.CertificateGenerator$.generateCertificate(CertificateGenerator.scala:84)
[error] play.api.libs.ws.ssl.CertificateGenerator$.generateRSAWithSHA256(CertificateGenerator.scala:35)
[error] play.api.libs.ws.ssl.AlgorithmCheckerSpec$$anonfun$1$$anonfun$apply$4.apply(AlgorithmCheckerSpec.scala:32)
[error] play.api.libs.ws.ssl.AlgorithmCheckerSpec$$anonfun$1$$anonfun$apply$4.apply(AlgorithmCheckerSpec.scala:27)
@jroper

This comment has been minimized.

Show comment
Hide comment
@jroper

jroper Mar 4, 2015

Member

That's the second time I've seen that. @play-pull-request-validator try again.

Member

jroper commented Mar 4, 2015

That's the second time I've seen that. @play-pull-request-validator try again.

@benmccann

This comment has been minimized.

Show comment
Hide comment
@benmccann

benmccann Mar 4, 2015

Contributor

The tests passed now

Contributor

benmccann commented Mar 4, 2015

The tests passed now

@richdougherty

This comment has been minimized.

Show comment
Hide comment
@richdougherty

richdougherty Mar 4, 2015

Member

Great. I'm OK for this PR to be merged now.

Member

richdougherty commented Mar 4, 2015

Great. I'm OK for this PR to be merged now.

jroper added a commit that referenced this pull request Mar 4, 2015

@jroper jroper merged commit 7ad6ffb into playframework:master Mar 4, 2015

2 checks passed

jenkins-pr-validator Merged build finished.
Details
typesafe-cla-validator All users have signed the CLA
Details

@richdougherty richdougherty deleted the richdougherty:akka-http-1.0-M4 branch Mar 4, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment