Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude externalized resources from application jar in dist #4522

Merged
merged 1 commit into from May 22, 2015

Conversation

jroper
Copy link
Member

@jroper jroper commented May 21, 2015

Fixes #4512

  • Build an additional sans-externalized jar that doesn't contain the externalized resources when externalized resources is true
  • Include this jar in the script classpath, and exclude the normal jar, when externalized resources is true

Fixes playframework#4512

* Build an additional sans-externalized jar that doesn't contain the
  externalized resources when externalized resources is true
* Include this jar in the script classpath, and exclude the normal jar,
  when externalized resources is true
@richdougherty
Copy link
Member

LGTM

marcospereira added a commit that referenced this pull request May 22, 2015
Exclude externalized resources from application jar in dist
@marcospereira marcospereira merged commit 848329b into playframework:master May 22, 2015
@jroper jroper deleted the externalized-exclude branch May 22, 2015 05:07
@mkurz
Copy link
Member

mkurz commented May 22, 2015

Could this be backported to 2.4.x? I run into the same issue.

@marcospereira
Copy link
Member

@jroper suggested that we can add this to 2.4.1 later.

@jroper jroper added this to the 2.4.1 milestone May 26, 2015
@jroper
Copy link
Member Author

jroper commented May 29, 2015

Backported to 2.4.x: 755ec9f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[2.4.0-RC5] conf/logback.xml occures twice in distribution classpath
4 participants