Actor system static refs refactoring #476

merged 0 commits into from Oct 10, 2012


None yet
2 participants

jroper commented Oct 9, 2012

This commit does the following:

  • Removes race conditions in Promise.system and Invoker.system that were causing Play to leak threads and our builds to hang
  • Cleans up Invoker shutdown, so it can be just shutdown by calling reset()
  • Removes unnecessary static access of Invoker.system() in WebSocketHandler, since the class that implements it already has non static access to an invoker
  • Looks up defaultTimeout direct from Play configuration, rather than going indirectly to play configuration through loading an actor system
  • Gives ReloadableApplication its own actor system, so that it doesn't reload in the actor system of the application that it's reloading

jroper merged commit 3799a15 into playframework:master Oct 10, 2012


sadache commented Oct 10, 2012

I can't seem to find this.


jroper commented Oct 11, 2012

@sadache Sorry, I modified the commit, and updated my repository using --force, which caused GitHub to close the request. Here's a new pull request:


@baloo baloo pushed a commit to baloo/Play20 that referenced this pull request Oct 11, 2012

@joscha joscha Ticket #476 ba3b022

@mudittuli mudittuli pushed a commit to mudittuli/Play20 that referenced this pull request Oct 23, 2012

@joscha @pk11 joscha + pk11 merge Ticket #476 2a9de2e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment