Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Actor system static refs refactoring #476

Merged
merged 0 commits into from

2 participants

@jroper
Owner

This commit does the following:

  • Removes race conditions in Promise.system and Invoker.system that were causing Play to leak threads and our builds to hang
  • Cleans up Invoker shutdown, so it can be just shutdown by calling reset()
  • Removes unnecessary static access of Invoker.system() in WebSocketHandler, since the class that implements it already has non static access to an invoker
  • Looks up defaultTimeout direct from Play configuration, rather than going indirectly to play configuration through loading an actor system
  • Gives ReloadableApplication its own actor system, so that it doesn't reload in the actor system of the application that it's reloading
@jroper jroper merged commit 3799a15 into from
@sadache
Collaborator

I can't seem to find this.

@jroper
Owner

@sadache Sorry, I modified the commit, and updated my repository using --force, which caused GitHub to close the request. Here's a new pull request:

#480

@baloo baloo referenced this pull request from a commit in baloo/Play20
@joscha joscha Ticket #476 ba3b022
@mudittuli mudittuli referenced this pull request from a commit in mudittuli/Play20
@joscha joscha merge Ticket #476 2a9de2e
@nicmarti nicmarti referenced this pull request from a commit
@joscha joscha Ticket #476 b37a6ce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Sorry, commit information is not available for this pull request.

Something went wrong with that request. Please try again.