Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for play.editor setting #6009

Merged
merged 1 commit into from Apr 14, 2016

Conversation

Projects
None yet
4 participants
@wsargent
Copy link
Member

commented Apr 8, 2016

Fixes

Fixes #3892

Purpose

The play.editor setting was not being applied -- this change ensures that error pages can read the value in for the DefaultHttpErrorHandler singleton object.

@wsargent wsargent force-pushed the wsargent:fix-play-editor-setting branch from 26a9d13 to e867beb Apr 9, 2016

"link the error line if play.editor is configured" in {
// This path happens from play.core.server.Server.getHandlerFor:
//
// def logExceptionAndGetResult(e: Throwable): Left[Future[Result], Nothing] = {

This comment has been minimized.

Copy link
@benmccann

benmccann Apr 10, 2016

Contributor

can this be deleted?

@wsargent wsargent force-pushed the wsargent:fix-play-editor-setting branch from e867beb to 8259ab2 Apr 14, 2016

@wsargent

This comment has been minimized.

Copy link
Member Author

commented Apr 14, 2016

@benmccann comment deleted

@gmethvin gmethvin merged commit fc86a2e into playframework:master Apr 14, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
typesafe-cla-validator All users have signed the CLA
Details

@gmethvin gmethvin added this to the 2.5.2 milestone Apr 14, 2016

@gmethvin

This comment has been minimized.

Copy link
Member

commented Apr 14, 2016

2.5.x: 41f8c14

@wsargent wsargent deleted the wsargent:fix-play-editor-setting branch Apr 14, 2016

wsargent added a commit that referenced this pull request Jun 23, 2016

[doc] fix play.editor configuration documentation
Fixes #5270

Updates documentation to reflect fix made in #6009

wsargent added a commit to wsargent/playframework that referenced this pull request Aug 1, 2016

gmethvin added a commit that referenced this pull request Aug 2, 2016

[doc] fix play.editor configuration documentation (#6372)
* [doc] fix play.editor configuration documentation

Fixes #5270

Updates documentation to reflect fix made in #6009

* Update documentation based on feedback

* Add PLAY_EDITOR environment variable

wsargent added a commit to wsargent/playframework that referenced this pull request Oct 25, 2016

[doc] fix play.editor configuration documentation (playframework#6372)
* [doc] fix play.editor configuration documentation

Fixes playframework#5270

Updates documentation to reflect fix made in playframework#6009

* Update documentation based on feedback

* Add PLAY_EDITOR environment variable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.