Get host properly even if full URI is invalid #6072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -26,6 +26,14 @@ class RequestHeaderSpec extends Specification { | |||
| val rh = DummyRequestHeader("GET", "https://example.com:8080/test", Headers(HOST -> "playframework.com")) | |||
| rh.host must_== "example.com:8080" | |||
| } | |||
| "absolute uri with port and invalid characters" in { | |||
| val rh = DummyRequestHeader("GET", "https://example.com:8080/classified-search/classifieds?version=GTI|V8", Headers(HOST -> "playframework.com")) | |||
| rh.host must_== "example.com:8080" | |||
There was a problem hiding this comment.
Should be consistent with java.net.URL?
scala> import java.net.URL
import java.net.URL
scala> val url = new URL("https://example.com:8080/classified-search/classifieds?version=GTI|V8")
url: java.net.URL = https://example.com:8080/classified-search/classifieds?version=GTI|V8
scala> url.getHost
res0: String = example.com
There was a problem hiding this comment.
Here we're trying to get the host + port (that is what Host is in HTTP), so we need example.com:8080. rh.domain returns example.com.
|
Backport to 2.5.x: 898910d |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6066
This uses a regex since we are only trying to extract the host and port, and we don't really care if the rest of the URI is valid. I think this is a better solution than throwing an exception unexpectedly, especially since in many cases the host is just the value of the
Hostheader and has nothing to do with the request URI.