Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update framework/src/play/src/main/java/play/mvc/Controller.java #616

Merged
merged 1 commit into from Dec 16, 2012
Merged

Update framework/src/play/src/main/java/play/mvc/Controller.java #616

merged 1 commit into from Dec 16, 2012

Conversation

@kentcdodds
Copy link

@kentcdodds kentcdodds commented Dec 14, 2012

Just a spelling update (fix) for the javadoc of public static String session(String key) :)

Just a spelling update (fix) for the javadoc of public static String session(String key) :)
@jroper
Copy link
Member

@jroper jroper commented Dec 14, 2012

Thankyou for your contribution. Would you mind signing our CLA?

http://www.typesafe.com/contribute/cla

@kentcdodds
Copy link
Author

@kentcdodds kentcdodds commented Dec 14, 2012

Done. Thanks!

jroper added a commit that referenced this issue Dec 16, 2012
Update framework/src/play/src/main/java/play/mvc/Controller.java
@jroper jroper merged commit 63fcc02 into playframework:master Dec 16, 2012
kentcdodds
Copy link

kentcdodds commented on 1242b6d Aug 3, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just leaving a note to say thanks for accepting this commit. This was my first ever contribution to open source. It was quite small, but it got me started. Thanks :-)

jroper
Copy link
Member

jroper commented on 1242b6d Aug 3, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kentcdodds, thanks for letting us know! Looks like you contribute heavily to open source these days, I'm glad we were part of getting you started.

@note89
Copy link

@note89 note89 commented Nov 19, 2015

Great things started here :)

@kentcdodds
Copy link
Author

@kentcdodds kentcdodds commented Nov 19, 2015

😄 they certainly did for me @note89 :D

@richdougherty
Copy link
Member

@richdougherty richdougherty commented Nov 20, 2015

@kentcdodds: have some 🍰.

@VikasHanumegowda
Copy link

@VikasHanumegowda VikasHanumegowda commented May 11, 2017

Wow...a thank you note after almost 3 years........NICE:-D

@Adimvicky
Copy link

@Adimvicky Adimvicky commented Nov 22, 2018

Wow. I'm heavily inspired by this PR and it's comment thread.

@TheCoderFish
Copy link

@TheCoderFish TheCoderFish commented Jan 2, 2019

I got my first PR accepted today as well !!!

@rohitkrishna094
Copy link

@rohitkrishna094 rohitkrishna094 commented Aug 15, 2019

Kentcdodds must thank the person who actually made that spelling mistake without which he wouldn't be making so many open source contributions these days. 😅

@junibrosas
Copy link

@junibrosas junibrosas commented Jan 30, 2020

Hi @kentcdodds, your blog got me here. Inspiring.

@ghost
Copy link

@ghost ghost commented Apr 15, 2020

Hi @kentcdodds, your blog got me here. Inspiring.

same here

@ghost
Copy link

@ghost ghost commented Aug 22, 2020

Waow

@gim224
Copy link

@gim224 gim224 commented Oct 29, 2020

awesome!

@jannomeister
Copy link

@jannomeister jannomeister commented Dec 10, 2020

hi @kentcdodds , thank you for writing that blog ❤️

@geeqib23
Copy link

@geeqib23 geeqib23 commented Jan 22, 2021

This gives me a good feeling!

@ad99526
Copy link

@ad99526 ad99526 commented Feb 11, 2021

@kentcdodds Would be a nostalgic feeling, your blog got me here

@Poonam-raj
Copy link

@Poonam-raj Poonam-raj commented Mar 13, 2021

Your blog and this PR makes me feel like contributing to Open Source isn't actually as impossible to get into as it feels at first, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet