Update framework/src/play/src/main/java/play/mvc/Controller.java#616
Update framework/src/play/src/main/java/play/mvc/Controller.java#616jroper merged 1 commit intoplayframework:masterfrom kentcdodds:patch-1
Conversation
Just a spelling update (fix) for the javadoc of public static String session(String key) :)
|
Thankyou for your contribution. Would you mind signing our CLA? |
|
Done. Thanks! |
Update framework/src/play/src/main/java/play/mvc/Controller.java
|
Great things started here :) |
|
😄 they certainly did for me @note89 :D |
|
@kentcdodds: have some 🍰. |
|
Wow...a thank you note after almost 3 years........NICE:-D |
|
Wow. I'm heavily inspired by this PR and it's comment thread. |
|
I got my first PR accepted today as well !!! |
|
Kentcdodds must thank the person who actually made that spelling mistake without which he wouldn't be making so many open source contributions these days. 😅 |
|
Hi @kentcdodds, your blog got me here. Inspiring. |
same here |
|
Waow |
|
awesome! |
|
hi @kentcdodds , thank you for writing that blog ❤️ |
|
This gives me a good feeling! |
|
@kentcdodds Would be a nostalgic feeling, your blog got me here |
|
Your blog and this PR makes me feel like contributing to Open Source isn't actually as impossible to get into as it feels at first, thank you! |
|
Thanks Kent, landed here from your blogpost. For some reason I thought contributing to Open Source was something waaaay different and have penciled in a plan to be ready in 6 months. LOL. After only a little research, I'm sure even I could have figured out "value" was spelled wrong. Haha. What a great spring board, yet again you start a ripple that effects change in others. Inspiring. |
|
Can someone please link the blog post from Kent that everyone is talking about here? Thank you! |
|
Here's the blog post: https://kentcdodds.com/blog/2010s-decade-in-review |
|
J |
|
Wow so here things started for Kent. Very Inspiring. |
18 participants
Just a spelling update (fix) for the javadoc of public static String session(String key) :)