Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update framework/src/play/src/main/java/play/mvc/Controller.java #616

Merged
merged 1 commit into from Dec 16, 2012

Conversation

@kentcdodds
Copy link

kentcdodds commented Dec 14, 2012

Just a spelling update (fix) for the javadoc of public static String session(String key) :)

Just a spelling update (fix) for the javadoc of public static String session(String key) :)
@jroper

This comment has been minimized.

Copy link
Member

jroper commented Dec 14, 2012

Thankyou for your contribution. Would you mind signing our CLA?

http://www.typesafe.com/contribute/cla

@kentcdodds

This comment has been minimized.

Copy link
Author

kentcdodds commented Dec 14, 2012

Done. Thanks!

jroper added a commit that referenced this pull request Dec 16, 2012
Update framework/src/play/src/main/java/play/mvc/Controller.java
@jroper jroper merged commit 63fcc02 into playframework:master Dec 16, 2012
@kentcdodds

This comment has been minimized.

Copy link

kentcdodds commented on 1242b6d Aug 3, 2015

Just leaving a note to say thanks for accepting this commit. This was my first ever contribution to open source. It was quite small, but it got me started. Thanks :-)

This comment has been minimized.

Copy link
Member

jroper replied Aug 3, 2015

Hi @kentcdodds, thanks for letting us know! Looks like you contribute heavily to open source these days, I'm glad we were part of getting you started.

@note89

This comment has been minimized.

Copy link

note89 commented Nov 19, 2015

Great things started here :)

@kentcdodds

This comment has been minimized.

Copy link
Author

kentcdodds commented Nov 19, 2015

😄 they certainly did for me @note89 :D

@richdougherty

This comment has been minimized.

Copy link
Member

richdougherty commented Nov 20, 2015

@kentcdodds: have some 🍰.

@VikasHanumegowda

This comment has been minimized.

Copy link

VikasHanumegowda commented May 11, 2017

Wow...a thank you note after almost 3 years........NICE:-D

@Adimvicky

This comment has been minimized.

Copy link

Adimvicky commented Nov 22, 2018

Wow. I'm heavily inspired by this PR and it's comment thread.

@TheCoderFish

This comment has been minimized.

Copy link

TheCoderFish commented Jan 2, 2019

I got my first PR accepted today as well !!!

@rohitkrishna094

This comment has been minimized.

Copy link

rohitkrishna094 commented Aug 15, 2019

Kentcdodds must thank the person who actually made that spelling mistake without which he wouldn't be making so many open source contributions these days. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.