Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.5.x] Fix unsafe usage of WS client in tests #6564

Merged
merged 2 commits into from Sep 20, 2016

Conversation

Projects
None yet
3 participants
@wsargent
Copy link
Member

commented Sep 15, 2016

Fixes #6506

Uses a try-with-resources to auto-close the ws client after use, and uses the default test server port. Since this is a functional test, it's fine to use a different WSClient than the one in the server.

@wsargent wsargent changed the title Fix unsafe usage of WS client in tests [2.5.x] Fix unsafe usage of WS client in tests Sep 15, 2016

@cchantep cchantep merged commit 5ba320f into playframework:2.5.x Sep 20, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
typesafe-cla-validator All users have signed the CLA
Details

@wsargent wsargent deleted the wsargent:fix-6506 branch Sep 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.