Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code updation of HttpConfiguration for compactness and performance #6644

Merged
merged 3 commits into from Oct 13, 2016

Conversation

Projects
None yet
2 participants
@mrsushil118
Copy link

commented Oct 13, 2016

Pull Request Checklist

  • Have you read How to write the perfect pull request?
  • Have you read through the contributor guidelines?
  • Have you signed the Lightbend CLA?
  • Have you [squashed your commits]? (Optional, but makes merge messages nicer.)
  • Have you added copyright headers to new files?
  • Have you checked that both Scala and Java APIs are updated?
  • Have you updated the documentation for both Scala and Java sections?
  • Have you added tests for any changed functionality?

Helpful things

Fixes

Fixes #xxxx

Purpose

For code performance and compactness.

Background Context

Why did you take this approach?

References

 #6634 

Sushil added some commits Oct 10, 2016

Sushil
Updated code of HttpConfiguration.scala file
Refactored CookiesConfiguration case class
Sushil
Refactored HttpConfiguration scala file
Updated code of CookiesConfiguration case class

@mrsushil118 mrsushil118 changed the title Code correction Code updation of HttpConfiguration for compactness and performance Oct 13, 2016

@gmethvin gmethvin merged commit 0eb7aa3 into playframework:master Oct 13, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
typesafe-cla-validator All users have signed the CLA
Details

@mrsushil118 mrsushil118 deleted the mrsushil118:code_correction branch Oct 14, 2016

wsargent pushed a commit to wsargent/playframework that referenced this pull request Oct 18, 2016

Sushil Kumar Will Sargent
Code updation of HttpConfiguration for compactness and performance (p…
…layframework#6644)

* Replaced pattern matching with if-else for compactness and performance

* Updated code of HttpConfiguration.scala file
Refactored CookiesConfiguration case class

* Refactored HttpConfiguration scala file
Updated code of CookiesConfiguration case class

wsargent added a commit to wsargent/playframework that referenced this pull request Oct 25, 2016

Code updation of HttpConfiguration for compactness and performance (p…
…layframework#6644)

* Replaced pattern matching with if-else for compactness and performance

* Updated code of HttpConfiguration.scala file
Refactored CookiesConfiguration case class

* Refactored HttpConfiguration scala file
Updated code of CookiesConfiguration case class
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.