Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse IPv4-mapped IPv6 addresses in forward headers #6698

Merged

Conversation

Projects
None yet
3 participants
@richdougherty
Copy link
Member

commented Nov 3, 2016

Fixes #6629.

I also changed to use Guava's IP address parser instead of the standard Java parser. The Java parser will make DNS lookups for non-IP addresses. I don't think we need DNS lookups so the Guava parser is probably better.

Cc @swoopster-sb.

Parse IPv4-mapped IPv6 addresses in forward headers
Fixes #6629.

I also changed to use Guava's IP address parser instead of the
standard Java parser. The Java parser will make DNS lookups for
non-IP addresses. I don't think we need DNS lookups so the Guava
parser is probably better.

@gmethvin gmethvin merged commit b03e47c into playframework:master Nov 5, 2016

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
typesafe-cla-validator All users have signed the CLA
Details

gmethvin added a commit that referenced this pull request Nov 12, 2016

Parse IPv4-mapped IPv6 addresses in forward headers (#6698)
Fixes #6629.

I also changed to use Guava's IP address parser instead of the
standard Java parser. The Java parser will make DNS lookups for
non-IP addresses. I don't think we need DNS lookups so the Guava
parser is probably better.

@mkurz mkurz added this to the 2.5.10 milestone Dec 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.