Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Multipart form data parts with optional quotes #6731

Merged
merged 3 commits into from Nov 16, 2016

Conversation

Projects
None yet
4 participants
@Discipe
Copy link
Contributor

commented Nov 14, 2016

##Fix
Multipart form data parts have optional quotes. This was already fixed for "filename" param, but not for regular parameters.

##References

I've also commented on this issue:
#6275

Update Multipart.scala
Multipart form data parts have optional quotes. This was already fixed for "filename" param, but not for regular parameters.
@schmitch

This comment has been minimized.

Copy link
Member

commented Nov 14, 2016

could you provide a test case?

oh and also this fix has some test failure's so I guess it's not quite correct.

Discipe added some commits Nov 15, 2016

@gmethvin gmethvin changed the title Update Multipart.scala Fix Multipart form data parts with optional quotes Nov 16, 2016

@gmethvin gmethvin merged commit b2dab17 into playframework:master Nov 16, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
typesafe-cla-validator All users have signed the CLA
Details

gmethvin added a commit that referenced this pull request Nov 16, 2016

wsargent added a commit to wsargent/playframework that referenced this pull request Nov 16, 2016

@Discipe Discipe deleted the Discipe:patch-1 branch Nov 21, 2016

erguven added a commit to erguven/playframework that referenced this pull request Nov 26, 2016

@mkurz mkurz added this to the 2.5.10 milestone Dec 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.