Call relative and canonical path support #7839
Pull Request Checklist
Add a feature to
Due to several issues with
The implementation is in Java and self-contained within the
I also included a suite of tests to support variations of paths to relativize and canonicalize.
Feature proposal on the
The text was updated successfully, but these errors were encountered:
Thanks for the review. I'll follow up with another commit shortly.
@gmethvin There are several reasons I chose to port Python's impl. instead of using the Java Class Library.
So while it's possible to use the JCL at the end of the day (with some massaging) I just feel that it's not the appropriate thing to do given that the options available are meant to be used with the filesystem and not URL's. However, if you or the rest of the team feel that you would prefer that I can update the PR accordingly.
@gmethvin I updated it to the
@marcospereira What documentation page and section would recommend updating? The main reference to
LMK where you think the most appropriate place to document this feature would be and I'll add a commit.
Thanks a ton @gmethvin . I was getting mixed up between the doc package namespaces and the code sample namespaces. I doublechecked the rendered output and everything looks good. Your commit fixed the failing documentation tests.
I think we're ready for a final review. Thanks for your patience.
* Call relative and canonical path support * Move relative & canonical impl to Paths util type. Rename relative -> relativeTo. Full names for dir constants. Dropped first params list from scala Call relative method. * Move Paths to play.core.j namespace * Moved to play.core package * Re-factor tests * Relative routes documentation * Docs tests fixes * Fix package structure * Fix refs to code samples