New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.6.x]: Handle database not available in Prod/Dev/Test modes #8524

Merged
merged 2 commits into from Jul 18, 2018

Conversation

Projects
None yet
1 participant
@marcospereira
Copy link
Member

marcospereira commented Jul 18, 2018

Backports #8522.

marcospereira added some commits Jul 18, 2018

Handle database not available in Prod/Dev/Test modes (#8522)
In #8497 we did not handle other modes besides test. In Prod and Dev
modes, there is a log entry that requires the database URL and, to get
the database URL, Play was trying to get datasource metadata, which
requires a connection.

Then the log entry forced the database connection pool to initialize
and fail. The new implementation gets the configured URL instead.

@marcospereira marcospereira merged commit b48d291 into playframework:2.6.x Jul 18, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
typesafe-cla-validator All users have signed the CLA
Details

@marcospereira marcospereira deleted the marcospereira:backport-8522-init-without-a-database-prod-dev-test branch Jul 18, 2018

@marcospereira marcospereira added this to the Play 2.6.17 milestone Jul 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment