WIP: remove guava #8528
WIP: remove guava #8528
Conversation
| @@ -52,7 +50,7 @@ public Twitter(WSClient ws) { | |||
|
|
|||
| public Result auth() { | |||
| String verifier = request().getQueryString("oauth_verifier"); | |||
| if (Strings.isNullOrEmpty(verifier)) { | |||
| if (verifier == null || verifier == "") { | |||
There was a problem hiding this comment.
verifier.isEmpty will yield NullPointerException if verifier == null is true
| def withTempDir[T](block: File => T) = { | ||
| val temp = GFiles.createTempDir() | ||
| val temp = Files.createTempDirectory(System.currentTimeMillis() + "-1") |
There was a problem hiding this comment.
well GFIles.createTempDir tried to create 5 temp dirs before failing, I guess we can omit that behavior, but maybe I create a small code change for that behavior or I keep guava as Test scoped, but I didn't decided yet which is the best choice.
There was a problem hiding this comment.
Since it is test code, I would say to keep your change and if it becomes a problem we can revisit it.
|
For |
| @@ -99,7 +99,7 @@ public final Self configure(Map<String, Object> conf) { | |||
| * @return a copy of this builder configured with the key=value | |||
| */ | |||
| public final Self configure(String key, Object value) { | |||
| return configure(ImmutableMap.of(key, value)); | |||
| return configure(Collections.singletonMap(key, value)); | |||
| @@ -4,7 +4,6 @@ | |||
|
|
|||
| package play.inject.guice; | |||
|
|
|||
| import com.google.common.collect.ImmutableMap; | |||
| import com.google.inject.Module; | |||
There was a problem hiding this comment.
Should this com.google.inject.Module also be removed?
There was a problem hiding this comment.
@rakeshhny Module is the part of Guice, not Guava
|
@schmitch do you still want this to land in Play 2.7? |
|
sadly I do not have time to complete that for 2.7 :( |
|
Tentatively adding the milestone |
|
Removing from 2.7.0 milestone. |
Warning this PR is not 100% done yet and is just a preview (still needs to remove some occurences) (i just wanted to get it out, since it floated around on my computer for some time)
The hardest part of removing guava will be the following two classes (which is not done yet):
and maybe
Everything else is just replacing the stuff from guava, with stuff that we already have in our framework, like
CharStreamsor some kind ofPrimitiveschecks that we have in some kind of different form.Purpose
removes guava
currently I think guava is one of the greatest library of all the time. however it's freaking aweful if a framework depend on it, since first of all guava is quite big (2.6mb), second we only use like 2-3 classes from it and the
InetAddressstuff, so that we do not need to rely on the JavaInetAddresswhich sometimes might try to resolve a ip/host (unnecessarily), for that I pulled in a new scala library from comcast, called ip4s which makes ip parsing, etc quite easy and comes with a relativ small size <200kb. and last it means that sometimes upgrades to guava are impossible in user code.we also use a lot of
Immutable*however the Maps aren't really needed since they won't leak into user code and theImmutableListstuff can be replaced by java8 code that makes list immutableThis PR helps that people who need guava can actually use the latest and greatest guava and probably reduce the size of play for all scala users that might never need guava at all.