New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More logs during Play's evolution #8550

Merged
merged 1 commit into from Aug 7, 2018

Conversation

Projects
None yet
3 participants
@tanin47
Copy link
Contributor

tanin47 commented Aug 2, 2018

One problem that I have occasionally is that, when an error occurs during Evolution, it's difficult to figure out which statement causes the error.

I'd see an error like: invalid character at position 61 without any pointer to which statement causes the error. This PR alleviates the problem.

This partly solves #8468. There's also a short discussion here: https://discuss.lightbend.com/t/should-we-add-more-logging-to-plays-evolutions/1460

@marcospereira
Copy link
Member

marcospereira left a comment

Use debug level?

I think this is not something most of the people will want. So using debug level will ensure people need to opt-in.

@tanin47 tanin47 force-pushed the tanin47:log-evolutions branch from 78b0811 to 009f196 Aug 3, 2018

@tanin47

This comment has been minimized.

Copy link
Contributor

tanin47 commented Aug 3, 2018

Done. Thank you for the suggestion.

@marcospereira
Copy link
Member

marcospereira left a comment

LGTM.

Thank you, @tanin47.

Also, I think we can backport this change to 2.6.x.

@marcospereira marcospereira merged commit 01d5982 into playframework:master Aug 7, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
typesafe-cla-validator All users have signed the CLA
Details

@tanin47 tanin47 deleted the tanin47:log-evolutions branch Aug 8, 2018

@tanin47 tanin47 restored the tanin47:log-evolutions branch Aug 8, 2018

@tanin47

This comment has been minimized.

Copy link
Contributor

tanin47 commented Aug 8, 2018

That would be awesome. How do I backport it? Do I merely create a PR against 2.6.x?

@marcospereira

This comment has been minimized.

Copy link
Member

marcospereira commented Aug 8, 2018

Hi @tanin47, don't worry.

I will backport it manually later. :-)

Thanks again.

@tanin47 tanin47 deleted the tanin47:log-evolutions branch Aug 8, 2018

marcospereira added a commit that referenced this pull request Aug 16, 2018

@marcospereira

This comment has been minimized.

Copy link
Member

marcospereira commented Aug 16, 2018

Backport to 2.6.x: 1456000

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment