New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the stop hook from ActorSystemProvider #8553

Merged
merged 1 commit into from Aug 7, 2018

Conversation

Projects
None yet
3 participants
@TimMoore
Copy link
Contributor

TimMoore commented Aug 6, 2018

The stopHook returned from ActorSystemProvider.start has been a no-op function since 38ef3eb (#8406). This removes some extra complexity dealing with the hook.

This changes the interface of ActorSystemProvider, but given that the stopHook no longer worked as promised, this breaking change seems like a better alternative.

Fixes #8534.

@TimMoore TimMoore self-assigned this Aug 6, 2018

Remove the stop hook from ActorSystemProvider
The `stopHook` returned from `ActorSystemProvider.start` has been a
no-op function since 38ef3eb (#8406). This removes some extra complexity
dealing with the hook.

This changes the interface of `ActorSystemProvider`, but given that the
`stopHook` no longer worked as promised, this breaking change seems like
a better alternative.

Fixes #8534.

@TimMoore TimMoore force-pushed the TimMoore:remove-stop-hook branch from 5118884 to a91a433 Aug 6, 2018

@gmethvin
Copy link
Member

gmethvin left a comment

lgtm

* also returns a function that will be called when `close()` is called. This allows
* any resources associated with the value to be closed.
*/
private[play] abstract class ClosableLazy[T >: Null <: AnyRef, C] {

This comment has been minimized.

@gmethvin

gmethvin Aug 6, 2018

Member

Nice that we can remove this code!

@marcospereira
Copy link
Member

marcospereira left a comment

👍

Thanks, @TimMoore.

@marcospereira marcospereira merged commit 784e9ab into playframework:master Aug 7, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
typesafe-cla-validator All users have signed the CLA
Details

@TimMoore TimMoore deleted the TimMoore:remove-stop-hook branch Aug 10, 2018

@TimMoore TimMoore added this to the Play 2.7.0 milestone Dec 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment