New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CoordinatedShutdoownSupport public but internal #8583

Merged
merged 2 commits into from Aug 27, 2018

Conversation

Projects
None yet
3 participants
@marcospereira
Copy link
Member

marcospereira commented Aug 27, 2018

Purpose

The API needs to be public so that we can better use it in Lagom. But it is not supposed to be used in users code.

Make CoordinatedShutdoownSupport public but internal
The API needs to be public so that we can better use it in Lagom.
* deprecation policy.
*/
// This is public so that it can be used in Lagom without any hacks or copy-and-paste.
object CoordinatedShutdownSupport {

This comment has been minimized.

@ignasi35

ignasi35 Aug 27, 2018

Member

Could we annotate with @InternalApi ?

This comment has been minimized.

@renatocaval

renatocaval Aug 27, 2018

Contributor

what about to add it under an internal package?

This comment has been minimized.

@marcospereira

marcospereira Aug 27, 2018

Member

Done for both.

I've used the same convention Lagom is using to internal packages (internal as a parent package).

@marcospereira marcospereira merged commit 7f7ee5c into playframework:master Aug 27, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
typesafe-cla-validator All users have signed the CLA
Details

@marcospereira marcospereira deleted the marcospereira:public-akka-cs-support branch Aug 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment