New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update akka 2.5.16 #8590

Merged
merged 2 commits into from Sep 4, 2018

Conversation

Projects
None yet
6 participants
@marcospereira
Member

marcospereira commented Aug 31, 2018

Purpose

This backports #8437 and #8589 so that we can have an updated version of Akka in Play 2.6.x.

Akka 2.5.12 introduced a fix that causes source compatibility issues (see akka/akka#24575). This should not affect most of the users though. Also, Akka 2.5.13 brings some API changes for Akka Typed and if you are using it in your Play application, there are some changes you need to make. These changes are okay according to Akka binary policy rules since Akka Typed is still marked as a "may change" module. Internally, Play does not uses Akka Typed, so these changes don't affect us.

Background Context

We need to update Akka version now because there is a security fix in Akka 2.5.16.

References

  1. https://akka.io/blog/news/2018/04/13/akka-2.5.12-released
  2. https://akka.io/blog/news/2018/06/08/akka-2.5.13-released
  3. https://akka.io/blog/news/2018/07/13/akka-2.5.14-released
  4. https://akka.io/blog/news/2018/08/24/akka-2.5.15-released
  5. https://akka.io/blog/news/2018/08/29/akka-2.5.16-security-fix-released

schmitch and others added some commits May 24, 2018

@FranklinYinanDing

This comment has been minimized.

Contributor

FranklinYinanDing commented Aug 31, 2018

@marcospereira Thanks for the quick fix! Would this security issue affect Play 2.4?

@gmethvin

This comment has been minimized.

Member

gmethvin commented Aug 31, 2018

Technically the security issue was in akka-remote, which Play does not depend on, so it shouldn't make any difference unless you are using that library.

For affected versions see https://doc.akka.io/docs/akka/current/security/2018-08-29-aes-rng.html#affected-versions. Specifically, the issue affects systems with Akka 2.5.0 - 2.5.15 that use Akka Remoting/Cluster with TLS and have configured the TLS random-number-generator to AES128CounterSecureRNG or AES256CounterSecureRNG.

@FranklinYinanDing to answer your question, this could not affect an application using Play 2.4, since Play 2.4 does not work with Akka 2.5.

@gmethvin

Just make sure you note the breaking change in the next release announcement.

@dwijnand

No strong feelings. LGTM.

@marcospereira marcospereira merged commit 2261350 into playframework:2.6.x Sep 4, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
typesafe-cla-validator All users have signed the CLA
Details

@marcospereira marcospereira deleted the marcospereira:update-akka-2.5.16 branch Sep 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment