New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guice 4.2.1 with better JDK 11 support #8657

Merged
merged 1 commit into from Oct 4, 2018

Conversation

Projects
None yet
4 participants
@mkurz
Member

mkurz commented Oct 3, 2018

Check the diff from 4.2.0.

Most notable Guice upgraded ASM and cglib which should bring better JDK11 support.

BTW: The Guice team is planning to release an even newer version as soon as ASM 7 final released (currently in beta). That should happen "in the next weeks". ASM 7 should bring even better JDK11 support.

@mkurz mkurz added this to the Play 2.7.0 milestone Oct 3, 2018

@marcospereira

👍

Ready to merge after a green build.

@gmethvin gmethvin merged commit 32da519 into playframework:master Oct 4, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
typesafe-cla-validator All users have signed the CLA
Details

@renatocaval renatocaval removed the in progress label Oct 4, 2018

@mkurz mkurz deleted the mkurz:guice421 branch Oct 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment