New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid publishing microbenchmarks and integration tests artifacts #8845

Merged
merged 3 commits into from Nov 30, 2018

Conversation

Projects
None yet
5 participants
@marcospereira
Member

marcospereira commented Nov 29, 2018

Microbenchmarks weren't being published anymore, but they weren't also
being aggregated. This aggregates the project again but configures it not to release artifacts.

Integration tests on the other side are still being published, but this
is not intentional since this is an internal artifact used only to test
Play itself.

Fixes #7743.

Avoid publishing microbenchmarks and integration tests artifacts
Microbenchmarks weren't being published anymore, but they weren't also
being aggregated. This aggregates the project again but configure it to
not publish artifacts.

Integration tests on the other side are still being published, but this
is not intentional since this is an internal artifact used only to test
Play itself.

Fixes #7743.
// https://www.scala-sbt.org/1.x/docs/Multi-Project.html#Aggregation
//
// Keep in mind that specific configurations (like skip in publish) will be respected.
lazy val aggreatedProjects = Seq[ProjectReference](

This comment has been minimized.

@PromanSEW

PromanSEW Nov 29, 2018

Contributor

Typo: aggregatedProjects

This comment has been minimized.

@marcospereira

marcospereira Nov 29, 2018

Member

Fixed. :-)
Thank you, @PromanSEW.

@ignasi35 ignasi35 merged commit b335f3e into playframework:master Nov 30, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
typesafe-cla-validator All users have signed the CLA
Details
// https://www.scala-sbt.org/1.x/docs/Multi-Project.html#Aggregation
//
// Keep in mind that specific configurations (like skip in publish) will be respected.
lazy val aggregatedProjects = Seq[ProjectReference](

This comment has been minimized.

@dwijnand

dwijnand Nov 30, 2018

Member

Did you know there's a aggregateProjects DSL entry in sbt?

This could be just

aggregateProjects(
  PlayProject,
  PlayGuiceProject,
  ...
)

without having to val (lazy val it, at that), and add it there.

See https://github.com/sbt/sbt/blob/v0.13.17/main/src/main/scala/sbt/internals/DslAst.scala (ignore the typo in the scaladoc of DslAggregate, it's aggregateProjects).

// be removed when we move to sbt 1.
PgpKeys.publishSigned := {},
publish := {},
publishLocal := {}

This comment has been minimized.

@dwijnand

dwijnand Nov 30, 2018

Member

How paranoid are you? Sometimes you can't take any chances.

This comment has been minimized.

@marcospereira

marcospereira Nov 30, 2018

Member

Not enough apparently. 🤣

@marcospereira marcospereira deleted the marcospereira:disable-publishing-tests-benchs branch Nov 30, 2018

marcospereira added a commit that referenced this pull request Dec 4, 2018

Avoid publishing microbenchmarks and integration tests artifacts (#8845)
* Avoid publishing microbenchmarks and integration tests artifacts

Microbenchmarks weren't being published anymore, but they weren't also
being aggregated. This aggregates the project again but configure it to
not publish artifacts.

Integration tests on the other side are still being published, but this
is not intentional since this is an internal artifact used only to test
Play itself.

Fixes #7743.

* Fix typo
@marcospereira

This comment has been minimized.

Member

marcospereira commented Dec 4, 2018

Backport to 2.7.x: 59b4b1c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment