New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scala 2.12.8 #8863

Merged
merged 1 commit into from Dec 7, 2018

Conversation

Projects
None yet
3 participants
@mkurz
Copy link
Member

mkurz commented Dec 6, 2018

@marcospereira
Copy link
Member

marcospereira left a comment

LGTM. Thank you, @mkurz.

Let's merge when we got a green build.

@marcospereira

This comment has been minimized.

Copy link
Member

marcospereira commented Dec 7, 2018

This can be backported to 2.6.x and 2.7.x.

@marcospereira

This comment has been minimized.

Copy link
Member

marcospereira commented Dec 7, 2018

@mkurz

This comment has been minimized.

Copy link
Member Author

mkurz commented Dec 7, 2018

Did someone change the GitHub repository settings?
I can't merge this pull request because it says "This branch is out-of-date with the base branch". This wasn't the case before...
Please see https://help.github.com/articles/enabling-required-status-checks/.
Did someone enabled the config " Require branches to be up to date before merging"?
Also see https://help.github.com/articles/types-of-required-status-checks/

It's a bit annoying to always have to either merge with master branch or rebase on top of it to be able to actually merge the pull request within GitHub... I think the way it was before was working quite well...

@mkurz mkurz merged commit d374072 into playframework:master Dec 7, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
typesafe-cla-validator All users have signed the CLA
Details

@mkurz mkurz deleted the mkurz:Scala-2.12.8 branch Dec 7, 2018

marcospereira added a commit that referenced this pull request Dec 7, 2018

@marcospereira

This comment has been minimized.

Copy link
Member

marcospereira commented Dec 7, 2018

Backport to 2.7.x: 3516a7b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment