Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd dispositionType to FilePart and FileInfo (which defaults to "form-data") #8878
Conversation
mkurz
added some commits
Dec 13, 2018
mkurz
added
the
status:needs-backport
label
Dec 13, 2018
renatocaval
added
the
status:in-progress
label
Dec 13, 2018
mkurz
requested a review
from
marcospereira
Dec 13, 2018
mkurz
merged commit 9264a6e
into
playframework:master
Dec 13, 2018
mkurz
deleted the
mkurz:dispositionType
branch
Dec 13, 2018
renatocaval
removed
the
status:in-progress
label
Dec 13, 2018
added a commit
that referenced
this pull request
Dec 21, 2018
This comment has been minimized.
This comment has been minimized.
|
Backport to 2.7.x: e20d30f |
marcospereira
removed
the
status:needs-backport
label
Dec 21, 2018
marcospereira
added this to the Play 2.7.0 milestone
Dec 21, 2018
renatocaval
referenced this pull request
Jan 11, 2019
Closed
Document changes in FileInfo and FilePart in Migration27.md #8934
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
mkurz commentedDec 13, 2018
The disposition type of a multipart-form upload is not always
form-databut can also be e.g.file- see #8527. This pull request reflects that fact in the rest of the code.I need this pull request merged because it's a prerequisite for another fix releated to multipart-forms that I have in line.