New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dispositionType to FilePart and FileInfo (which defaults to "form-data") #8878

Merged
merged 3 commits into from Dec 13, 2018

Conversation

Projects
None yet
3 participants
@mkurz
Copy link
Member

mkurz commented Dec 13, 2018

The disposition type of a multipart-form upload is not always form-data but can also be e.g. file - see #8527. This pull request reflects that fact in the rest of the code.

I need this pull request merged because it's a prerequisite for another fix releated to multipart-forms that I have in line.

mkurz added some commits Dec 13, 2018

@marcospereira
Copy link
Member

marcospereira left a comment

LGTM.

@mkurz mkurz merged commit 9264a6e into playframework:master Dec 13, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
typesafe-cla-validator All users have signed the CLA
Details

@mkurz mkurz deleted the mkurz:dispositionType branch Dec 13, 2018

marcospereira added a commit that referenced this pull request Dec 21, 2018

Add dispositionType to FilePart and FileInfo (which defaults to "form…
…-data") (#8878)

* Add dispositionType

* dispositionType defaults to "form-data"

* Make MiMa smile
@marcospereira

This comment has been minimized.

Copy link
Member

marcospereira commented Dec 21, 2018

Backport to 2.7.x: e20d30f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment