Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.7.x] Log warning for @Singleton java actions #9045

Merged
merged 2 commits into from Feb 19, 2019

Conversation

Projects
None yet
3 participants
@mkurz
Copy link
Member

commented Feb 19, 2019

Same like #8989 for 2.7.x but just logs a warning instead of aborting the request.

@mkurz mkurz added this to the Play 2.7.1 milestone Feb 19, 2019

@mkurz mkurz requested a review from marcospereira Feb 19, 2019

@marcospereira
Copy link
Member

left a comment

LGTM.

@mkurz mkurz removed the in progress label Feb 19, 2019

@mkurz mkurz merged commit e4983d3 into playframework:2.7.x Feb 19, 2019

3 checks passed

Mergify — Summary 1 rule matches and 2 potential rules
Details
Travis CI - Pull Request Build Passed
Details
typesafe-cla-validator All users have signed the CLA
Details

@mkurz mkurz deleted the mkurz:disallow_singleton_jaction27 branch Feb 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.