Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add status(...), ok(...), methods with Path param #9048

Merged
merged 1 commit into from Feb 20, 2019

Conversation

Projects
None yet
3 participants
@mkurz
Copy link
Member

commented Feb 19, 2019

In the Scala API we do have sendPath(...) and in the Java API we also have statusHeaderObj.sendPath(...).
However, we do not have shortcuts for the static methods status(...), ok(...), etc.

BTW: The code was generated with https://github.com/jroper/play-source-generator. However that project wasn't up-to-date, therefore I provided an update: jroper/play-source-generator#3.

@mkurz mkurz added this to the Play 2.7.1 milestone Feb 19, 2019

@mkurz

This comment has been minimized.

Copy link
Member Author

commented Feb 19, 2019

For some reason the GitHub diff looks like I edited lines. however that isn't the case - I just added lines.

@mkurz mkurz removed the in progress label Feb 19, 2019

@marcospereira
Copy link
Member

left a comment

LGTM.

@marcospereira marcospereira merged commit 287ca31 into playframework:master Feb 20, 2019

3 checks passed

Mergify — Summary 1 rule matches and 2 potential rules
Details
Travis CI - Pull Request Build Passed
Details
typesafe-cla-validator All users have signed the CLA
Details

marcospereira added a commit that referenced this pull request Feb 20, 2019

@marcospereira

This comment has been minimized.

Copy link
Member

commented Feb 20, 2019

Backport to 2.7.x: e015752

@mkurz mkurz deleted the mkurz:JavaAPIsendPath branch Feb 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.