Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes HTTP and HTTPS port binding in DEV mode #9093

merged 3 commits into from Mar 29, 2019


None yet
3 participants
Copy link

commented Mar 14, 2019

Fixes #9055

@mkurz mkurz added this to the Play 2.7.1 milestone Mar 14, 2019

@@ -47,7 +47,22 @@ object DevServerStart {
* compiled with different versions of Scala.
def mainDevHttpMode(buildLink: BuildLink, httpPort: Int, httpAddress: String): ReloadableServer = {
mainDev(buildLink, Some(httpPort), Option(System.getProperty("https.port")).map(Integer.parseInt), httpAddress)

This comment has been minimized.

Copy link

mkurz Mar 14, 2019

Author Member

System.getProperty("https.port") definitely needs to be removed here, because the only place we decide which ports are set is within Reloader.scala. Here we don't decide anything anymore.

Copy link

left a comment


@mergify mergify bot merged commit efcfcbe into playframework:master Mar 29, 2019

3 checks passed

Mergify — Summary 2 rules match
Travis CI - Pull Request Build Passed
typesafe-cla-validator All users have signed the CLA

@mkurz mkurz deleted the mkurz:fixPortsDevMode branch Mar 30, 2019

renatocaval added a commit that referenced this pull request Apr 1, 2019

Fixes HTTP and HTTPS port binding in DEV mode (#9093)
* Fixes HTTP and HTTPS port binding in DEV mode

* Formatting

This comment has been minimized.

Copy link

commented Apr 1, 2019

Backported to 2.7.x (c34e72e)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.