Misc cleanups and not crashing on Grails 2.2 #1

Merged
merged 7 commits into from Feb 6, 2013

Conversation

Projects
None yet
3 participants
Collaborator

tomdcc commented Dec 22, 2012

This includes some testing that I was doing to get service names de-cglib-munged on Grails 1.3.x, and also making sure that the plugin won't halt startup of a vanilla Grails 2.2 app. It can't find the service declared in the cache plugin which is getting loaded after the profiler plugin. I guess the namespacing in grails 2.2 might be causing services to be added to the spring config later than just the services plugin. I haven't fully fixed that, but for the time being it will ignore any services which haven't been added to the spring config yet.

@tomdcc tomdcc referenced this pull request in tomdcc/grails-miniprofiler Dec 28, 2012

Closed

getting profiler working on 2.2 #3

Peter, do you have an idea when this could be merged? It would be great to get the profiler working on 2.2

@pledbrook pledbrook merged commit 7ddda2e into pledbrook:master Feb 6, 2013

Owner

pledbrook commented Feb 6, 2013

It looks like an alternative strategy for profiling services is required. This fix means that some services/beans don't get profiled, which isn't ideal. It's not clear which services won't be profiled with the current code unfortunately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment