Skip to content

Conversation

@gjong
Copy link
Contributor

@gjong gjong commented Nov 14, 2025

Breaking change

Update for a new API.

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to the application)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SonarCloud found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@gjong gjong force-pushed the feature/refresh-api-in-pieces branch from e734b8b to 5929178 Compare November 28, 2025 14:15
gjong added 28 commits November 28, 2025 15:15
- Introduced `ContractCommandController` and `ContractFetcherController` to handle contract creation, updates, deletions, and queries.
- Added API documentation for contracts, including new parameters and schema updates.
- Implemented new tests for contract operations under `ContractTest` to ensure proper functionality.
- Enhanced responses and request schemas with additional fields like `attachmentCode` and required attributes specification.
- Switched Gradle plugin configuration for several modules to `io.micronaut.library`.
- Added `TagCommandController` and `TagFetcherController` to handle tag creation, deletion, and lookup operations.
- Updated API contract with endpoints for managing tags, including `/api/tags` and `/api/tags/{tag}`.
- Implemented tests under `TagTest` to validate the tag operations.
- Extended `PledgerRequests` to support tag-related API requests, including create, search, and delete functions.
- Added `SystemInformationController` to provide system-level details, starting with account type lookup functionality.
- Implemented `getAccountTypes` method to fetch all account types from `AccountTypeProvider`.
- Added test `listAllAccountTypes` to verify account type fetching in `BankAccountTest`.
- Extended `PledgerRequests` with support for `/api/account-types` endpoint.
- Added `ExportController` to handle profile export requests.
- Implemented transaction mappings with `TransactionMapper` for detailed response transformation.
- Updated response YAML schemas and added required attributes for transaction splits.
- Added `ExportTest` to validate export-related functionalities.
- Enhanced `PledgerContext` and `PledgerRequests` for export flows.
- Introduced new dependency on Bouncy Castle for secure file handling.
- Added `ScheduleCommandController` and `ScheduleFetcherController` for managing transaction schedules, including creation, updates, deletions, and lookup operations.
- Implemented `ScheduleMapper` to translate domain models into API responses.
- Added validation message keys for source and destination account errors.
- Enhanced schedule-related error handling with specific exception messages.
- Added `StatisticsBalanceController` with endpoints for computing balances grouped by date, filtered balances, and partitioned balances.
- Updated balance-related request and response schemas, including new required attributes and data types.
- Refactored `ScheduleFetcherController` for improved readability and consistency.
- Implemented type changes in balance request schema (`integer` to `long`) for several properties.
- Updated `ScheduleFetcherController` to refine end date validation logic.
- Added new tests for schedule search and deletion in `TransactionTest`.
- Extended `PledgerRequests` with methods for schedule deletion and search operations.
- Enhanced `PledgerContext` to support schedule creation with date limits.
- Added `TransactionCommandController` and `TransactionFetcherController` for managing transactions, supporting creation, updates, deletions, and lookups.
- Updated transaction YAML schemas to include new attributes (`deleted`, `importSlug`) and refined data types (`long` to `integer`).
- Enhanced `TransactionTest` with new test cases for transaction lifecycle (create, update, fetch, delete) validations.
- Extended `PledgerRequests` to support transaction API operations with improved request logging.
- Added `deleted` property to `Transaction` domain model to handle soft deletion scenarios.
…s, and related functionalities.

- Added `TaskEngineController` and `VariableEngineController` for managing tasks and variables.
- Introduced new model classes (`ListVariable`, `WrappedVariable`) and updated contract schemas (`task-variable-map.yaml`, `variable.yaml`).
- Refined test setup (`ProcessEngineTest`) and expanded test coverage for process workflows.
- Added filtering support for contracts in transaction APIs.
- Updated Gradle dependencies for runtime and test modules.
…ovements.

- Introduced `@Timed` annotations for monitoring key methods across modules (`learning`, `budget`, `rest`, and `llm`).
- Enhanced logging in `ScheduleCommandController` and `ContractCommandController` to include more contextual details.
- Updated YAML schemas and `messages.properties` for improved API responses and error messages.
- Refined Gradle dependencies to include support for Micrometer and Hibernate Validator.
- Added new `income` field to `budget.yaml` responses and updated related mappers.
…ring.

- Corrected split transaction `computeType` mapping in `TransactionMapper`.
- Refined balance request logic in `StatisticsBalanceController` to handle missing accounts and adjusted income/expense type filtering.
- Updated `BudgetFetcherController` to modify expense name filter behavior.
- Introduced summaries to OpenAPI YAML files for better documentation.
- Deprecated `task-variable-map.yaml` and restructured `VariableMap` implementation.
- Added `BatchImporterController` to manage batch importer operations.
- Enhanced `TaskEngineController` for task and variable handling.
- Updated models (`VariableMap`, `CSVConfiguration`) to support refined functionality.
- Applied OpenAPI 3.1 configuration in `application/openapi.properties`.
- Added Learning Rule API with `CommandController` and `FetcherController` for managing rules and groups.
- Included YAML schema updates to define responses and request structures for Learning Rule API.
- Added `RuleMapper`, `RuleTest`, and related controller tests.
- Updated existing test setups across modules to include `@Replaces` for `AuthenticationFacade` mocks.
- Introduced `RuleRemovedCommand` and `RuleRemovedHandler` for handling rule removal events.
- Adjusted Gradle configurations to include the Learning Rule API and its dependencies.
@gjong gjong merged commit 1ea33ad into master Dec 1, 2025
6 checks passed
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 1, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
58.1% Coverage on New Code (required ≥ 70%)

See analysis details on SonarQube Cloud

@gjong gjong deleted the feature/refresh-api-in-pieces branch December 1, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants