Skip to content
This repository has been archived by the owner on Nov 7, 2022. It is now read-only.

Fix horizontal creation #455

Merged
merged 2 commits into from
Jul 22, 2022
Merged

Fix horizontal creation #455

merged 2 commits into from
Jul 22, 2022

Conversation

Darmody
Copy link
Contributor

@Darmody Darmody commented Jul 21, 2022

fix #353

  1. always create new line after insert horizontal-rule
  2. allows only paragraph and sub-list inside list

ref: #308

@Darmody Darmody requested a review from toadfanszz as a code owner July 21, 2022 15:33
@codecov
Copy link

codecov bot commented Jul 21, 2022

Codecov Report

Merging #455 (01e34cb) into main (8a01c97) will increase coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #455      +/-   ##
==========================================
+ Coverage   69.66%   69.68%   +0.01%     
==========================================
  Files        1060     1060              
  Lines       18027    18023       -4     
  Branches     2496     2495       -1     
==========================================
  Hits        12559    12559              
+ Misses       5155     5151       -4     
  Partials      313      313              
Flag Coverage Δ
frontend-unit 65.33% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../src/extensions/blocks/horizontalRule/inputRule.ts 31.25% <0.00%> (+6.25%) ⬆️
...-editor/src/extensions/blocks/listItem/listItem.ts 100.00% <ø> (ø)
...-editor/src/extensions/blocks/taskItem/taskItem.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a01c97...01e34cb. Read the comment docs.

@github-actions
Copy link
Contributor

This pull request has been built and is available for preview at pr455.mashcard.dev.
Default username/password is test1@example.com & test1234.

Devtools

@stackia stackia merged commit 3219adf into main Jul 22, 2022
@stackia stackia deleted the fix-horizontal-creation branch July 22, 2022 03:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After Numbered List, Divider can not create a new line
2 participants