New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pop-up's "Service road attributes" not displaying localized service value #52

Closed
IgorEliezer opened this Issue Jul 12, 2018 · 4 comments

Comments

Projects
None yet
2 participants
@IgorEliezer
Contributor

IgorEliezer commented Jul 12, 2018

Example: https://www.openstreetbrowser.org/#railway-infrastructure/w203530982&map=20/-23.04587/-47.83887&categories=railway-infrastructure

In the example's pop-up you'll see Service road attributes: yard, but the field for "yard" is shown unlocalized ("yard", "siding", "spur"), even thought they have their proper translations.


On an unrelated issue: just noticed electrified=no doesn't have a translation entry. I'll add it next time.

@IgorEliezer IgorEliezer changed the title from Popu-p's "Service road attributes" not displaying localized service value to Pop-up's "Service road attributes" not displaying localized service value Jul 12, 2018

@plepe

This comment has been minimized.

Owner

plepe commented Jul 12, 2018

Good point. Fixed. The usage=* and service=* values are now also included in the description in the list.

Please note, that I changed the translation a bit, the tags service and usage now always have a railway=rail prefix (when used with railway of course): https://github.com/plepe/openstreetmap-tag-translations/blob/543e9c37dc5999d63596308b342ab884a3ae920a/tags/pt-br.json#L716-L727

About the electrified=no: it's not necessary to translate, because no is translated by tag:*=no.

@plepe plepe closed this Jul 12, 2018

@IgorEliezer

This comment has been minimized.

Contributor

IgorEliezer commented Jul 16, 2018

About the electrified=no: it's not necessary to translate, because no is translated by tag:*=no.

Sorry I should have been specific. In "Railway Electrification" subcategory, the string "not electrified" is not translated on both left panel and pop-up. Example.

Also tested on German, Spanish and Russian to be sure.

@plepe

This comment has been minimized.

Owner

plepe commented Jul 18, 2018

I understand.

I added an extra translation for "tag:electrified=no", which is used by this category from now on: plepe/openstreetmap-tag-translations@b52189e

@plepe

This comment has been minimized.

Owner

plepe commented Jul 25, 2018

Sorry, forgot to update the languages. It's online from now on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment