New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added signs for bicycle/fishing/electronics shop #31

Merged
merged 2 commits into from Jan 19, 2019

Conversation

Projects
None yet
2 participants
@wopfel
Copy link
Contributor

wopfel commented Jan 17, 2019

Hi,
First of all thank you very much for your openstreetbrowser project. It's a great service.

After searching for some shops I've discovered the emoji for the hairdresser, but the other shops had the default basket symbol.

image

I've searched for hairdresser and found the shop.json file. So I added entries for the other shops. For the electronics entry I chose a television emoji.

Please let me know if that's everything I had to do or if something is missing.

I'd be glad if you could merge this commit.

Kind regards,
Bernd

Original commit text:

Unicode symbols:
U+1F3A3: 馃帲 fishing (fishing pole and fish)
U+1F6B2: 馃毑 bicycle
U+1F4FA: 馃摵 electronics (a television)

To find the html entity (馃毑 for example) I've searched the web for the unicode string (U+1F6B2 for example).

Added signs for bicycle/fishing/electronics shop
Unicode symbols:
U+1F3A3: fishing (fishing pole and fish)
U+1F6B2: bicycle
U+1F4FA: electronics (a television)

To find the html entity (🚲 for example) I've searched the web for the unicode string (U+1F6B2 for example).
@plepe

This comment has been minimized.

Copy link
Owner

plepe commented Jan 17, 2019

That's great, thanks! You could also just copy the emoji into the code. You could also add icons from other icon sets, see https://github.com/plepe/OpenStreetBrowser/blob/master/doc/Icons.md

@wopfel

This comment has been minimized.

Copy link
Contributor Author

wopfel commented Jan 17, 2019

Hi Stephan,
Thanks for the hint 馃槂

@plepe plepe merged commit 4d17c85 into plepe:master Jan 19, 2019

@plepe

This comment has been minimized.

Copy link
Owner

plepe commented Jan 19, 2019

Thanks!

@wopfel

This comment has been minimized.

Copy link
Contributor Author

wopfel commented Feb 3, 2019

You're welcome. Thanks for merging!
And the changes are already live on your website I've seen a few days ago.

@wopfel wopfel deleted the wopfel:add-shop-symbols branch Feb 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment