New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FR translations #39

Merged
merged 1 commit into from Feb 11, 2019

Conversation

Projects
None yet
2 participants
@Cybereric
Copy link
Contributor

Cybereric commented Jan 31, 2019

In the menu "Infrastructure > Buildings" I have (in french) "Military zone: Bunker" ("Zone militaire: Bunker")
It should be "Military: Bunker" as it's a building

In the translation file I have :

  • "tag:military": "Zone militaire", for use with "landuse"
  • "tag:military=bunker": "Bunker", for use with building_type

I think you've used the wrong tag ;-)

Update FR translations
In the menu "Infrastructure > Buildings"  I have (in french) "Military zone: Bunker" ("Zone militaire: Bunker") 
It should be "Military: Bunker" as it's a building

In the translation file I have :

 - "tag:military": "Zone militaire",  for use with "landuse"
 - "tag:military=bunker": "Bunker",  for use with building_type 

I think you've used the wrong tag ;-)
@plepe

This comment has been minimized.

Copy link
Owner

plepe commented Feb 1, 2019

Hi!

I have a different view on the military issue:

  • tag:military - This key can be used with building and with landuse
  • tag:landuse=military - This should be (and is) "Zone militaire"

Anyway, the current situation is not ideal. What's missing is a tag building=military, which should bespecified with the military tag.

So I did the following:

  • I now added a building=military tag on https://wiki.openstreetmap.org/wiki/Key:building . This is now also used in the info page on building types.
  • Also, I changed the category to internally convert building=yes to building=military if a military tag is present. The value of the military key will be written in brackets, e.g. "Military (Barracks)".

I added tag:building=military to the language files and added more military values.

@plepe plepe merged commit 4783c37 into plepe:master Feb 11, 2019

@plepe

This comment has been minimized.

Copy link
Owner

plepe commented Feb 11, 2019

Sorry, I thought you might want to change something after my comment. Anyway, merged.

By the way, if you want, you can use the new weblate translations system: https://blog.openstreetbrowser.org/node/67

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment