Browse files

Holding a database transaction across N network operations is crazy t…

…alk, and in this case resulted in a number of hangs when othe things tried to access the DB when a scan was going on. I'm not completely sure of the repercusions of this change, but the hangs were totally bogus
  • Loading branch information...
1 parent 931ec40 commit 236402c23f71e605f0db9f5875c7355703764b14 @elan elan committed Jul 29, 2008
Showing with 0 additions and 2 deletions.
  1. +0 −2 xbmc/VideoInfoScanner.cpp
View
2 xbmc/VideoInfoScanner.cpp
@@ -387,7 +387,6 @@ namespace VIDEO
// needed to ensure the movie count etc is cached
for (int i=LIBRARY_HAS_VIDEO;i<LIBRARY_HAS_MUSICVIDEOS+1;++i)
g_infoManager.GetBool(i);
- m_database.BeginTransaction();
for (int i = 0; i < (int)items.Size(); ++i)
{
IMDB_EPISODELIST episodes;
@@ -636,7 +635,6 @@ namespace VIDEO
if(pDlgProgress)
pDlgProgress->ShowProgressBar(false);
- m_database.CommitTransaction();
m_database.Close();
return true;
}

0 comments on commit 236402c

Please sign in to comment.