Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added package toSwap #89

Merged
merged 10 commits into from Nov 4, 2019

Conversation

@drwm-base
Copy link
Contributor

drwm-base commented Oct 27, 2019

I wasn't able to get the toSwap function to work once I added it to index.js in the plexis folder. I checked the instructions but I wasn't missing anything. I don't really know why it's not working. It is set up exactly like every other function.

The function itself works, and has 5 test cases, testing different possible entries that might have not been accounted for. These test cases also run, the only one that doesn't is in plexis/test/index.js.

For some reason, it cannot find the toSwap function.

Fixes Issue #75

@drwm-base drwm-base changed the title Issue75 Added function toSwap Oct 27, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Oct 27, 2019

Codecov Report

Merging #89 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #89   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          33     34    +1     
  Lines         161    168    +7     
=====================================
+ Hits          161    168    +7
Impacted Files Coverage Δ
packages/toSwap/src/index.js 100% <100%> (ø)
@drwm-base

This comment has been minimized.

Copy link
Contributor Author

drwm-base commented Oct 28, 2019

I know what the problem is, I was missing the dist folder.

@brandon-m-skinner

This comment has been minimized.

Copy link
Contributor

brandon-m-skinner commented Oct 28, 2019

Hi @drwm-base

You're missing the entry into docs/pages/api.md for your new package.

Brandon

@drwm-base

This comment has been minimized.

Copy link
Contributor Author

drwm-base commented Oct 28, 2019

Thanks for the reminder, almost missed that!

@drwm-base drwm-base changed the title Added function toSwap Added package toSwap Oct 28, 2019
@drwm-base

This comment has been minimized.

Copy link
Contributor Author

drwm-base commented Oct 29, 2019

@vorillaz @brandon-m-skinner I added toSwap to the API. Is there anything else that I can do?

drwm-base added 2 commits Nov 1, 2019
@drwm-base

This comment has been minimized.

Copy link
Contributor Author

drwm-base commented Nov 1, 2019

@brandon-m-skinner I have updated to the most recent version, please let me know if there is anything I need to fix!

@vorillaz vorillaz merged commit 3914846 into plexis-js:master Nov 4, 2019
3 checks passed
3 checks passed
ci/circleci: test Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 100%)
Details
codecov/project 100% (+0%) compared to 078ebe0
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.