New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of Windows paths with parentheses #15

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
2 participants
@brad-mac
Contributor

brad-mac commented Jan 28, 2017

Hi Graham,

This PR fixes handling of paths that include parentheses on both MSWin32 (e.g. Strawberry Perl) and Cygwin for issue #12 .

I've added two functions (cmd_escape_path and powershell_escape_path) that are needed within the test suite; while I could have called them internally I thought it better to expose them. You may have different ideas though :-)

I also removed the skip of PowerShell testing under Cygwin as it tests just fine on my system. You may want to revert that if using PowerShell in conjunction with Cygwin is not something you'd want to do.

Finally, I added checks in the test suite to use type rather than cat on Windows systems.

Hope this helps!

Cheers

Brad

@plicease

This comment has been minimized.

Show comment
Hide comment
@plicease

plicease Jan 28, 2017

Owner

Thanks! I will take some time next week if not sooner to review your work.

Owner

plicease commented Jan 28, 2017

Thanks! I will take some time next week if not sooner to review your work.

@plicease

This comment has been minimized.

Show comment
Hide comment
@plicease

plicease Jan 28, 2017

Owner

Note: if powershell works from cygwin may also work under msys2, and may be worth checking. I think the reason I did the skip is that there were some environmental issues which were difficult to control that could cause problems.

Owner

plicease commented Jan 28, 2017

Note: if powershell works from cygwin may also work under msys2, and may be worth checking. I think the reason I did the skip is that there were some environmental issues which were difficult to control that could cause problems.

@brad-mac

This comment has been minimized.

Show comment
Hide comment
@brad-mac

brad-mac Jan 29, 2017

Contributor

It may indeed work for msys2; I'll install MingW on my test box some time this week and have a look.

Contributor

brad-mac commented Jan 29, 2017

It may indeed work for msys2; I'll install MingW on my test box some time this week and have a look.

@plicease

This comment has been minimized.

Show comment
Hide comment
@plicease

plicease Feb 1, 2017

Owner

Thanks! I've merged your changes (after rebasing) and this will go out to CPAN as 0.26.

Owner

plicease commented Feb 1, 2017

Thanks! I've merged your changes (after rebasing) and this will go out to CPAN as 0.26.

@plicease plicease closed this Feb 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment