New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check /proc/[pid]/comm for name to recognize tcsh properly #7

Merged
merged 1 commit into from Dec 19, 2017

Conversation

Projects
None yet
2 participants
@simbabque
Contributor

simbabque commented Dec 18, 2017

This is my entry for December in the Pull Request Challenge 2017.

It addresses the Linux part of the problem in #6. I am afraid I cannot really help with the Windows part as I don't have proper access to a Windows machine.

From http://man7.org/linux/man-pages/man5/proc.5.html

  /proc/[pid]/comm (since Linux 2.6.33)
         This file exposes the process's comm value—that is, the com‐
         mand name associated with the process.

This might or might not work to find tcsh, but if it fails, we can still continue with the other methods.

check /proc/[pid]/comm for name to recognize tcsh properly
From http://man7.org/linux/man-pages/man5/proc.5.html

>       /proc/[pid]/comm (since Linux 2.6.33)
>              This file exposes the process's comm value—that is, the com‐
>              mand name associated with the process.

This might or might not work to find tcsh, but if it fails, we can still continue with the other methods.

Addresses #6.
@plicease

This comment has been minimized.

Show comment
Hide comment
@plicease

plicease Dec 19, 2017

Owner

Thanks for making this a PR, I saw your commentary elsewhere and intended to encourage a PR but got lost in other things. I agree it doesn't really help windows, but it does potentially make the detection better on Linux!

Owner

plicease commented Dec 19, 2017

Thanks for making this a PR, I saw your commentary elsewhere and intended to encourage a PR but got lost in other things. I agree it doesn't really help windows, but it does potentially make the detection better on Linux!

@plicease plicease merged commit 93781ee into plicease:master Dec 19, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@simbabque simbabque deleted the simbabque:gh-6 branch Dec 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment