New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not need DateTime::Format::Strptime #2

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@thrig

thrig commented Feb 6, 2015

DateTime::Format::Strptime not needed; POSIX imports a strftime, and tests pass without DateTime::Format::Strptime. Add POD tests (which also all pass).

@plicease

This comment has been minimized.

Owner

plicease commented Feb 6, 2015

Interesting I had to go digging to figure out why DateTime::Format::Strptime is even in there at all and it looks like it came along with this commit

9c0ec99

for an "untemplate" function that was later removed here:

446ee14

so I'd definitely like to get rid of that.

The Pod tests are fine if they are completely optional and limited to release testing. See here:

http://www.dagolden.com/index.php/2008/stop-pod-tests-before-they-stop-you/

Thus please

  1. Remove them from test test_requires in the Build.PL, they already skip appropriately if Test::Pod or Test::Pod::Coverage are not installed.
  2. Add a plan skip_all to skip these tests unless the environment variable RELEASE_TESTING is set true.

Thanks!

@plicease

This comment has been minimized.

Owner

plicease commented Feb 8, 2015

Thanks again! These changes are incorporated with version 0.16 now on its way to CPAN.

@plicease plicease closed this Feb 8, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment