New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace IPC::Run3 with Capture::Tiny #15

Closed
wants to merge 10 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@paultcochrane
Contributor

paultcochrane commented Apr 22, 2017

As mentioned in issue #4, due to problems associated with IPC::Run3 it was wished to migrate the code to Capture::Tiny. The changes in this PR implement the required migration. If you have any questions or comments concerning this PR, please don't hesitate to contact me. If you want any part of the PR changed, please just say and I'll update it and resubmit.

@plicease

This comment has been minimized.

Show comment
Hide comment
@plicease

plicease Apr 22, 2017

Owner

cool! will definitely take a look at this soon

Owner

plicease commented Apr 22, 2017

cool! will definitely take a look at this soon

paultcochrane added some commits Apr 23, 2017

Align assignment operators above one another
... which makes the formatting of dist.ini conform to Perl-like best
practices.
Remove unnecessary return value from capture()
It turns out that the return value from capture() simply matches the
exit value from the called test script, which is extracted from `$?`
later anyway, hence the `$rv` is superfluous information and can be
removed.
@plicease

This comment has been minimized.

Show comment
Hide comment
@plicease

plicease May 1, 2017

Owner

I have merged this and made a DEV release as 1.19_01. Whether this makes it into the production version 1.20 depends entirely on cpantesters and testing with downstream modules (of which their are plenty!). I do earnestly hope this is permanent though. Thank you for taking the time to implement this and making the PR.

Owner

plicease commented May 1, 2017

I have merged this and made a DEV release as 1.19_01. Whether this makes it into the production version 1.20 depends entirely on cpantesters and testing with downstream modules (of which their are plenty!). I do earnestly hope this is permanent though. Thank you for taking the time to implement this and making the PR.

@paultcochrane

This comment has been minimized.

Show comment
Hide comment
@paultcochrane

paultcochrane May 1, 2017

Contributor

Awesome! Thanks for merging all the PRs! It's been my pleasure to try and help out :-)

Contributor

paultcochrane commented May 1, 2017

Awesome! Thanks for merging all the PRs! It's been my pleasure to try and help out :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment