NPM requires `resolved` URLs for github packages #1

Closed
domharrington opened this Issue Feb 13, 2014 · 1 comment

Projects

None yet

2 participants

@domharrington
Contributor

If you have this in your package.json:

"my-package": "git+ssh://git@github.com:githubuser/mypackage.git#v1",

This generates the following npm-shrinkwrap.json:

"my-package": {
  "version": "1",
  "from": "my-package@git+ssh://git@github.com:githubuser/mypackage.git#v1",
  "resolved": "git+ssh://git@github.com:githubuser/mypackage.git#sha1hash",
  "dependencies": {}
}

Using this module strips out the resolved URL. This isnt enough for NPM to resolve the module and results in the following:

npm ERR! Error: version not found: 1 : my-package/1

A possible solution is to look for .git in the from URL. If it is present, do not remove the resolved URL.

@serby
Contributor
serby commented Feb 17, 2014

Fixed in 1.0.0

@serby serby closed this Feb 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment