scripts as OFS.Folders increases ConflictErrors #497

Open
djay opened this Issue Nov 29, 2013 · 5 comments

Comments

Projects
None yet
3 participants

djay commented Nov 29, 2013

In the case where code has changed, if a lot of different requests start recompiling formulas. This adds items to and OFS.Folder which has no ability to do conflict resolution. This happens often when the request is a long one. Using a BTreeFolder instead should help. Ideally however it would be best to avoid writing data on reads.

@ghost ghost assigned jean Nov 29, 2013

jean added a commit that referenced this issue Nov 29, 2013

Use BTree folders instead of plain Folder
This is needed specifically for the /scripts/ folder;
see issue #497
Owner

ebrehault commented Nov 29, 2013

BTreeFolder would be definitely better.

Note: in Rapido, I have changed the approach regarding formula compilation: they are compiled just after being changed, so they are always already compiled when the user actually needs them. That's might be done in Plomino too.

Owner

jean commented Nov 29, 2013

Pull request submitted #498

Owner

jean commented Nov 29, 2013

@ebrehault we don't always know ahead of time what scripts will be needed. E.g. scripts generated from fields on subforms. But there are for sure a lot of scripts we can compile early.

Owner

jean commented Dec 3, 2013

@djay does #498 help? Can we close this issue?

djay commented Dec 3, 2013

I can't really put this into production yet I'm sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment