Skip to content
This repository
Browse code

Remove content-core ID from login_form. This removes the duplicate ID

that occurs on a page when using the login overlay.
This fixes https://dev.plone.org/ticket/12439
  • Loading branch information...
commit a35984231005f776860a7b2252cf67d9f46108ce 1 parent 32ba6ba
authored July 20, 2012
2  Products/CMFPlone/skins/plone_login/login_form.cpt
@@ -20,7 +20,7 @@
20 20
 <body>
21 21
     <metal:main fill-slot="main">
22 22
 
23  
-    <div id="content-core">
  23
+    <div>
24 24
         <metal:login define-macro="login"
25 25
             tal:define="auth nocall:context/acl_users/credentials_cookie_auth|context/cookie_authentication|nothing;
26 26
                         isURLInPortal nocall:context/portal_url/isURLInPortal;
5  docs/CHANGES.txt
@@ -8,7 +8,10 @@ Changelog
8 8
 4.2.1 (unreleased)
9 9
 ------------------
10 10
 
11  
-- Nothing changed yet.
  11
+- Remove content-core ID from login_form. This removes the duplicate ID
  12
+  that occurs on a page when using the login overlay.
  13
+  This fixes https://dev.plone.org/ticket/12439
  14
+  [cwainwright]
12 15
 
13 16
 
14 17
 4.2.0.1 (2012-07-02)

1 note on commit a359842

David Glick
Owner

This doesn't look right, since it'll mean there's no content-core when viewing the login form standalone (i.e. not as a popup). Instead maybe we can adjust the selector used in popupforms.js to filter the content used for the popup?

Please sign in to comment.
Something went wrong with that request. Please try again.