Permalink
Browse files

Remove content-core ID from login_form. This removes the duplicate ID

that occurs on a page when using the login overlay.
This fixes https://dev.plone.org/ticket/12439
  • Loading branch information...
Chrissy
Chrissy committed Jul 20, 2012
1 parent 32ba6ba commit a35984231005f776860a7b2252cf67d9f46108ce
Showing with 5 additions and 2 deletions.
  1. +1 −1 Products/CMFPlone/skins/plone_login/login_form.cpt
  2. +4 −1 docs/CHANGES.txt
@@ -20,7 +20,7 @@
<body>
<metal:main fill-slot="main">
- <div id="content-core">
+ <div>
<metal:login define-macro="login"
tal:define="auth nocall:context/acl_users/credentials_cookie_auth|context/cookie_authentication|nothing;
isURLInPortal nocall:context/portal_url/isURLInPortal;
View
@@ -8,7 +8,10 @@ Changelog
4.2.1 (unreleased)
------------------
-- Nothing changed yet.
+- Remove content-core ID from login_form. This removes the duplicate ID
+ that occurs on a page when using the login overlay.
+ This fixes https://dev.plone.org/ticket/12439
+ [cwainwright]
4.2.0.1 (2012-07-02)

1 comment on commit a359842

@davisagli

This comment has been minimized.

Show comment
Hide comment
@davisagli

davisagli Jul 22, 2012

Member

This doesn't look right, since it'll mean there's no content-core when viewing the login form standalone (i.e. not as a popup). Instead maybe we can adjust the selector used in popupforms.js to filter the content used for the popup?

Member

davisagli commented on a359842 Jul 22, 2012

This doesn't look right, since it'll mean there's no content-core when viewing the login form standalone (i.e. not as a popup). Instead maybe we can adjust the selector used in popupforms.js to filter the content used for the popup?

Please sign in to comment.