Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS issue on "Pattern options" tab in Resource Registries #1111

Closed
jcerjak opened this issue Sep 29, 2015 · 5 comments
Closed

CSS issue on "Pattern options" tab in Resource Registries #1111

jcerjak opened this issue Sep 29, 2015 · 5 comments

Comments

@jcerjak
Copy link
Member

jcerjak commented Sep 29, 2015

resource-registry-css-bug

@nikandroff
Copy link

Hello!
I took a look at this issue and it seems that I have found the problem.

It seems to me that there is a type at resourceregistry/pattern.resourceregistry.less file, line 93.
The style is attributed to a non-existent class .patternoptionsuse what is apparently a typo and has to be .patternoptions.
That is the reason why "pattern options" tab has the CSS issue: the padding style is not getting attributed there.

I would like to make a Pull Request for this issue. However, I am confused by the fact that changes in this .less file are not saved and applied after I relaunch Plone by bin/plonectl fg.

Could you advise how to see changes in my case?

@davilima6
Copy link
Member

davilima6 commented Mar 13, 2017

Hi, @nikandroff. This is inside the mockup package so first you have to install its dependencies. Get inside the directory you cloned the mockup repository to and type: sudo apt-get installl phantom-js && make bootstrap. After that you can generate the desired CSS files from the LESS ones using: make bundle-resourceregistry or make bundles for all bundles. See https://github.com/plone/mockup/blob/master/mockup/GETTING_STARTED.md

@newbazz
Copy link
Contributor

newbazz commented Dec 5, 2017

Hey i would like to help something on this issue, can someone please elaborate it.

@jensens
Copy link
Sponsor Member

jensens commented Aug 15, 2018

Still an issue in 5.1

@vincentfretin
Copy link
Member

This seems fixed in Plone 5.2.2. See screenshot, we have a <div class="form col-md-12"> the col-md-12 class provides a float:left that fixes the issue apparently. The parent <div class="row"> already provides the clear: both;
Capture d’écran de 2020-07-01 12-07-57
But I did the fix in plone/mockup#990 so the padding-top is the same as in Less variables tab. The changes will be picked up next time we do new bundles in plone.staticresources.
So with the rule applied this gives:
Capture d’écran de 2020-07-01 12-32-13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants