Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hard to integrate "contents" into theme #1258

Open
djay opened this issue Nov 23, 2015 · 4 comments
Open

hard to integrate "contents" into theme #1258

djay opened this issue Nov 23, 2015 · 4 comments

Comments

@djay
Copy link
Member

djay commented Nov 23, 2015

User problem

When you have a theme where you want to include selective parts of the UI such as contents, it's hard to integrate "Folder contents" into theme. Currently css for the folder contents seems to be contained in Barceloneta.

options

  1. Separate the folder contents css into its own bundle? (more requests)
  2. any other ideas?
@djay
Copy link
Member Author

djay commented Nov 23, 2015

Hi @bloodbare, @vangheem, there didn't seem to be an easy way except pull in all of barceloneta, which would break our theme. Is there another way we are missing?

@bloodbare
Copy link
Member

@djay afaik foldercontents css for its main usage is embedded in the https://github.com/plone/mockup/blob/master/mockup/patterns/structure/less/pattern.structure.less . It should be compiled in https://github.com/plone/Products.CMFPlone/blob/master/Products/CMFPlone/static/plone-logged-in.less

What is on barceloneta that is folder contents related?

@ivanteoh
Copy link
Member

I am not sure what is the extra. But refer to the image below, when the theme barceloneta is disabled (unthemed), the search box and button (on the right) were not styled nicely. In order to have that page displayed nicely, Barceloneta needs to be enabled.

Image of untheme

@bloodbare
Copy link
Member

then it must be solved on plone/mockup/patterns/structure/less/pattern.structure.less

In my opinion patterns should be rendered ok without the skin so they don't depend on the theme to be shown and used. Then each theme can decide how they want to render it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants