PLIP: Get rid of portal_quickinstaller #1340

mauritsvanrees · 2016-01-26T11:00:57Z

Proposer : Maurits van Rees

Seconder : @hvelarde

Abstract

No longer support installing via Extensions/install.py.

Motivation

There are two ways of installing products: GenericSetup and CMFQuickInstaller. Checking if a package is currently installed, means having to check portal_setup and portal_quickinstaller, or having code that makes sure those two are in sync. The syncing is mostly in place, with some recent changes, but supporting both remains tricky. Cleanup would make this code much easier to understand.

Assumptions

Some core packages need to actually get a GenericSetup profile instead of their current install.py (for example Products.Marshall). Some need to get an uninstall profile.

Proposal & Implementation

Update prefs_install_products_form browser view to only handle GenericSetup profiles.
Register this view also as @@installer for easier remembering.
Possibly create a utility instead that handles the basic operations.
When installing a product, use its default profile, instead of using the first profile found.
Warn before install when a product has no uninstall profile.
Change any core code that uses the portal_quickinstaller (mostly plone.app.upgrade and tests).
CMFQuickInstaller code should remain in Plone 5.x, but possibly stripped down and with deprecation warnings. Remove it in Plone 6. (plone.app.upgrade can get bare bones module patches to avoid possible breakage.)
Document what third party add-ons should do.

Deliverables

CMFPlone branch
plone.app.upgrade branch
CMFQuickInstaller branch
Branches for core packages that have no default or no uninstall profile yet.
Documentation

Risks

Third party add-ons that have no profile, are no longer installable.
We lose the automatic partial cleanup that CMFQuickInstaller does on uninstall (remove added skins, css, etc). The 'partial' part of this may be a benefit: a proper uninstall profile is now required instead of add-ons relying on the default cleanup being good enough.

Participants

Maurits van Rees

Note that CMFQuickInstaller is Plone specific, in spite of the CMF in the name. So compatibility with CMF is not an issue.

See http://sourceforge.net/p/plone/mailman/message/34390699/ for small initial discussion in August 2015.

The text was updated successfully, but these errors were encountered:

mauritsvanrees · 2016-01-26T11:03:24Z

Working on this at the Alpine City Strategic Sprint 2016 in Innsbruck, Austria.
WIP on CMFPlone branch get-rid-of-qi:
https://github.com/plone/Products.CMFPlone/tree/get-rid-of-qi
The prefs_install_products_form on that branch no longer uses portal_quickinstaller.

hvelarde · 2016-01-26T12:51:31Z

+1 I think is clear, implemented with enough time in advance, documentation, deprecation warnings and so on; makes a lot of sense.

@keul thoughts? in order to run Python code, are import steps in setuphandlers.py easy and/or powerful enough in your opinion?

keul · 2016-01-26T13:32:25Z

No, I'm -1 about this.

Setuphandlers are powerful, I always use them, but aren't they related to an installation already running? On the other hand install.py is something can be run at the very beginning, maybe checking Python version (OK, not so useful anymore nowadays) or trying to perform some import assumption.

However I like the fact that magic uninstall operation done by quickinstaller will gone.

mauritsvanrees · 2016-01-26T16:10:51Z

@keul: You mean you sometimes need to run some code before applying the first import step? I have not needed that so far, but I can imagine it. Fair point. That could easily be handled by this GenericSetup pull request I created earlier:
zopefoundation/Products.GenericSetup#24
I created that for the post_handler, but the pre_handler would help you.

keul · 2016-01-26T16:58:45Z

@mauritsvanrees yep! This can help (hoping to see this merged)

plone/Products.CMFPlone#1340

hvelarde · 2016-01-28T21:19:08Z

@mauritsvanrees what about reinstalls?

mauritsvanrees · 2016-01-28T21:49:02Z

Reinstalls are not supported. Basically that is already true in the current add-ons control panel.

But with the new setup a reinstall would really just be an uninstall and install, which is easy to do in an add-on if you need it. The old quick installer had a specific reinstall because this did not remove any portal objects that the install had added.

mauritsvanrees · 2016-01-29T10:45:41Z

Added plip config in coredev:
https://github.com/plone/buildout.coredev/blob/5.0/plips/plip1340-get-rid-of-qi.cfg

gforcada · 2016-01-30T01:30:38Z

And a jenkins job for it: http://jenkins.plone.org/view/PLIPs/job/plip-1340-QuickInstaller/

mauritsvanrees · 2016-01-30T08:34:31Z

Ah, sweet, thanks.

We can use get_installer in Plone 5.1 migrations. In earlier version we will keep using the portal_quickinstaller, because get_installer is not available. In a getToolByName call for portal_quickinstaller, we will pass a default of None, so an upgrade can still work if the portal tool has already been removed. In shared utility and base code, we will try to import get_installer, and fall back on the previous implementation. plone/Products.CMFPlone#1340

ebrehault · 2016-02-02T21:51:25Z

@mauritsvanrees, your PLIP has been approved by the Framework team, and @frapell is the one in charge of review your PR once it will be ready.

mauritsvanrees · 2016-02-05T17:27:00Z

Note to self. Todo: hidden products are no longer hidden:

Products.CMFUid (which is marked as not installed, probably because it has no metadata.xml)
plonetheme.barceloneta
plone.app.caching
plone.app.intid

frapell · 2016-02-08T18:42:06Z

@mauritsvanrees Do we have something analogue to the "isProductInstalled" we have in qi ? this is very helpful, and I remember having issues to know if a specific profile for a package was ran or not (for packages that include several profiles)

mauritsvanrees · 2016-02-08T21:02:33Z

With the new setup, we still have an is_product_installed method (or isProductInstalled as deprecated alias). It gets the default profile of the product. It then checks the only canonical place left: portal_setup. If the default profile has a last version other than unknown then we say it is installed.

This last check is done with a single line that does a call to portal_setup, but for ease of use I have added this as method is_profile_installed on the installer view. You can pass this a full profile id and get back True or False.

We can use get_installer in Plone 5.1 migrations. In earlier version we will keep using the portal_quickinstaller, because get_installer is not available. In a getToolByName call for portal_quickinstaller, we will pass a default of None, so an upgrade can still work if the portal tool has already been removed. In shared utility and base code, we will try to import get_installer, and fall back on the previous implementation. plone/Products.CMFPlone#1340

mauritsvanrees · 2016-02-09T22:57:55Z

Random idea out of scope for this plip.

Situation:

Install product A. This depends on profile B.
Uninstall product A. Profile B remains installed: uninstall routines for package A do not usually run an uninstall for profile B, because profile B may be required by other packages.

If the author of product A is really sure, he may add a metadata.xml in his uninstall profile that depends on the uninstall profile of package B.

Practically speaking: ATContentTypes depends on a profile from Archetypes, but when uninstalling ATContentTypes we are probably not going to run an uninstall profile for Archetypes. Well, in this case we might actually do it: if someone uninstalls ATCT there is no good reason to keep Archetypes installed.

An idea may be to add a cleanup control panel. It may be a part of the add-ons control panel. Or it may be more general, where it can also be a third party add-on (maybe part of ftw.upgrade). For our use case here: add a form that lists all products that are:

hidden from the add-ons control panel (INonInstallable)
currently installed
no other currently installed profiles depend on them

Just a few half baked ideas, but if someone wants to take this on, it may be good.

We can use get_installer in Plone 5.1 migrations. In earlier version we will keep using the portal_quickinstaller, because get_installer is not available. In a getToolByName call for portal_quickinstaller, we will pass a default of None, so an upgrade can still work if the portal tool has already been removed. In shared utility and base code, we will try to import get_installer, and fall back on the previous implementation. plone/Products.CMFPlone#1340

hvelarde · 2016-03-01T13:18:02Z

I have another idea/request: fire a couple of new events on add-on install and uninstall; if someone give us a hand, we can dedicate some resources to this.

jensens · 2016-09-20T20:33:05Z

Note to self:

plip config at https://github.com/plone/buildout.coredev/blob/5.0/plips/plip1340-get-rid-of-qi.cfg

So we have those merges:

Add uninstall profile Add uninstall profile Products.CMFFormController#4
Add uninstall profile Add uninstall profile Products.Archetypes#54
Added uninstall profile Added uninstall profile. plone.session#7
Added uninstall profile Added uninstall profile. Products.ATContentTypes#32
Use get_installer and make profile upgrade versions persistent Use get_installer and make profile upgrade versions persistent plone.app.testing#29
Get rid of qi Get rid of qi Products.CMFQuickInstallerTool#15
Get rid of qi Get rid of qi #1772

Also all GenericSetup changes were merged already.

Do not forget to create an issue in the docs repository.

jensens · 2016-09-20T20:39:26Z

@mauritsvanrees if you like to merge this yourself, I'am fine. You know better than I....

mauritsvanrees · 2016-09-20T20:47:34Z

Yeah, I might as well merge it myself. Will do.

mauritsvanrees · 2016-09-20T21:14:28Z

As basis for the docs, I have copied the GET_RID_OF_QI.rst from the CMFPlone plip branch to this new docs branch:
https://github.com/plone/documentation/tree/plip-1340-deprecate-qi

We can use get_installer in Plone 5.1 migrations. In earlier version we will keep using the portal_quickinstaller, because get_installer is not available. In a getToolByName call for portal_quickinstaller, we will pass a default of None, so an upgrade can still work if the portal tool has already been removed. In shared utility and base code, we will try to import get_installer, and fall back on the previous implementation. plone/Products.CMFPlone#1340

mauritsvanrees · 2016-09-20T21:38:43Z

The PLIP job is happy, but I want to do a final check before merging.

Two pull requests should be fine for Plone 5.0:

I test them in combination here: http://jenkins.plone.org/job/pull-request-5.0/1434/

For Plone 5.1 we have the same, plus two extra, for which the packages in 5.0 already use other branches:

I test them in combination here: http://jenkins.plone.org/job/pull-request-5.1/630/

We can use get_installer in Plone 5.1 migrations. In earlier version we will keep using the portal_quickinstaller, because get_installer is not available. In a getToolByName call for portal_quickinstaller, we will pass a default of None, so an upgrade can still work if the portal tool has already been removed. In shared utility and base code, we will try to import get_installer, and fall back on the previous implementation. plone/Products.CMFPlone#1340

mauritsvanrees · 2016-09-20T23:03:49Z

The 5.1 job succeeded, the 5.0 one had a few failures that should be easy to fix. Doing that now.

mauritsvanrees · 2016-09-21T00:42:28Z

The 5.0 job passes too.

But I should test plone/plone.app.upgrade#86 on Plone 4.3 as well: http://jenkins.plone.org/job/pull-request-4.3/406/

mauritsvanrees · 2016-09-21T09:53:29Z

4.3 passes too. Merging all now.

Branch: refs/heads/master Date: 2016-09-21T00:57:38+02:00 Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org> Commit: plone/plone.app.upgrade@45823b9 Support sites without portal_quickinstaller. We can use get_installer in Plone 5.1 migrations. In earlier version we will keep using the portal_quickinstaller, because get_installer is not available. In a getToolByName call for portal_quickinstaller, we will pass a default of None, so an upgrade can still work if the portal tool has already been removed. In shared utility and base code, we will try to import get_installer, and fall back on the previous implementation. plone/Products.CMFPlone#1340 Files changed: M CHANGES.rst M plone/app/upgrade/tests/base.py M plone/app/upgrade/utils.py M plone/app/upgrade/v30/tests.py M plone/app/upgrade/v31/betas.py M plone/app/upgrade/v40/alphas.py M plone/app/upgrade/v41/alphas.py M plone/app/upgrade/v42/final.py M plone/app/upgrade/v43/alphas.py M plone/app/upgrade/v43/final.py M plone/app/upgrade/v43/tests.py M plone/app/upgrade/v50/alphas.py M plone/app/upgrade/v50/betas.py Repository: plone.app.upgrade Branch: refs/heads/master Date: 2016-09-21T11:53:41+02:00 Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org> Commit: plone/plone.app.upgrade@949b0f9 Merge pull request #86 from plone/get-rid-of-qi Support sites without portal_quickinstaller. Files changed: M CHANGES.rst M plone/app/upgrade/tests/base.py M plone/app/upgrade/utils.py M plone/app/upgrade/v30/tests.py M plone/app/upgrade/v31/betas.py M plone/app/upgrade/v40/alphas.py M plone/app/upgrade/v41/alphas.py M plone/app/upgrade/v42/final.py M plone/app/upgrade/v43/alphas.py M plone/app/upgrade/v43/final.py M plone/app/upgrade/v43/tests.py M plone/app/upgrade/v50/alphas.py M plone/app/upgrade/v50/betas.py

Branch: refs/heads/master Date: 2016-09-07T01:21:27+02:00 Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org> Commit: plone/plone.app.testing@8dbbe78 Added test that the upgrade step registry gets rolled back. Files changed: M plone/app/testing/helpers.rst Repository: plone.app.testing Branch: refs/heads/master Date: 2016-09-07T01:21:27+02:00 Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org> Commit: plone/plone.app.testing@63c5177 In PloneSandboxLayer make profile upgrade versions persistent. This way installed profile versions get reset in teardown. Initially I added push and pop support for the various GS registries, but somehow that is handled fine already. Files changed: M CHANGES.rst M plone/app/testing/helpers.py M plone/app/testing/helpers.rst Repository: plone.app.testing Branch: refs/heads/master Date: 2016-09-07T01:21:28+02:00 Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org> Commit: plone/plone.app.testing@773220f Use get_installer instead of portal_quickinstaller when available. This is needed for Plone 5.1 and higher, plip 1340: plone/Products.CMFPlone#1340 Files changed: A plone/app/testing/profile/metadata.xml M CHANGES.rst M plone/app/testing/helpers.py M plone/app/testing/helpers.rst Repository: plone.app.testing Branch: refs/heads/master Date: 2016-09-21T11:53:53+02:00 Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org> Commit: plone/plone.app.testing@f424bbe Merge pull request #29 from plone/get-rid-of-qi Use get_installer and make profile upgrade versions persistent Files changed: A plone/app/testing/profile/metadata.xml M CHANGES.rst M plone/app/testing/helpers.py M plone/app/testing/helpers.rst

Branch: refs/heads/master Date: 2016-09-07T01:19:47+02:00 Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org> Commit: plone/Products.ATContentTypes@4f6f926 No longer register the archetypes skin. Products.Archetypes does that itself. Files changed: M CHANGES.rst M Products/ATContentTypes/profiles/base/skins.xml Repository: Products.ATContentTypes Branch: refs/heads/master Date: 2016-09-07T01:19:47+02:00 Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org> Commit: plone/Products.ATContentTypes@f31dee9 Added uninstall profile. This only removes the stuff from the base profile, not the others. Note that rolemap.xml does not support the 'remove' keyword for permissions, so we keep them. Note that this needs several fixes in GenericSetup and CMFPlone, but they have been merged. Files changed: A Products/ATContentTypes/profiles/uninstall/componentregistry.xml A Products/ATContentTypes/profiles/uninstall/controlpanel.xml A Products/ATContentTypes/profiles/uninstall/diff_tool.xml A Products/ATContentTypes/profiles/uninstall/skins.xml A Products/ATContentTypes/profiles/uninstall/toolset.xml A Products/ATContentTypes/profiles/uninstall/types.xml M CHANGES.rst M Products/ATContentTypes/configure.zcml M Products/ATContentTypes/setuphandlers.py M Products/ATContentTypes/tests/test_base_profile.py M Products/ATContentTypes/tests/test_installation.py Repository: Products.ATContentTypes Branch: refs/heads/master Date: 2016-09-07T01:19:47+02:00 Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org> Commit: plone/Products.ATContentTypes@b1882f3 Differentiate between uninstall and fulluninstall. The 'uninstall' profile belongs to the 'base' profile, which is the one that gets applied when you install ATContentTypes. The 'fulluninstall' profile belongs to the 'default' profile, which can only be installed through portal_setup. Do not try to install p.a.imaging/widgets. Their default profiles are dummies in Plone 5. Files changed: A Products/ATContentTypes/profiles.zcml A Products/ATContentTypes/profiles/fulluninstall/diff_tool.xml A Products/ATContentTypes/profiles/fulluninstall/metadata.xml A Products/ATContentTypes/profiles/fulluninstall/types.xml A Products/ATContentTypes/profiles/uninstall/metadata.xml M CHANGES.rst M Products/ATContentTypes/configure.zcml M Products/ATContentTypes/profiles/default/metadata.xml M Products/ATContentTypes/tests/test_base_profile.py M Products/ATContentTypes/tests/test_installation.py D Products/ATContentTypes/profiles/uninstall/diff_tool.xml D Products/ATContentTypes/profiles/uninstall/types.xml Repository: Products.ATContentTypes Branch: refs/heads/master Date: 2016-09-07T01:19:47+02:00 Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org> Commit: plone/Products.ATContentTypes@0762473 Give up on portal_quickinstaller of Plone 5.0. We need Plone 5.1 with the get_installer function from plone/Products.CMFPlone#1340 With 5.0 and the old QI you run into problems like: when the uninstall profile gets applied, the QI event handlers actually mark the product as installed... Files changed: M Products/ATContentTypes/tests/test_base_profile.py M Products/ATContentTypes/tests/test_installation.py Repository: Products.ATContentTypes Branch: refs/heads/master Date: 2016-09-07T01:20:37+02:00 Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org> Commit: plone/Products.ATContentTypes@e88e5a2 changelog Files changed: M CHANGES.rst Repository: Products.ATContentTypes Branch: refs/heads/master Date: 2016-09-21T11:54:01+02:00 Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org> Commit: plone/Products.ATContentTypes@be42b2a Merge pull request #32 from plone/get-rid-of-qi Added uninstall profile. Files changed: A Products/ATContentTypes/profiles.zcml A Products/ATContentTypes/profiles/fulluninstall/diff_tool.xml A Products/ATContentTypes/profiles/fulluninstall/metadata.xml A Products/ATContentTypes/profiles/fulluninstall/types.xml A Products/ATContentTypes/profiles/uninstall/componentregistry.xml A Products/ATContentTypes/profiles/uninstall/controlpanel.xml A Products/ATContentTypes/profiles/uninstall/metadata.xml A Products/ATContentTypes/profiles/uninstall/skins.xml A Products/ATContentTypes/profiles/uninstall/toolset.xml M CHANGES.rst M Products/ATContentTypes/configure.zcml M Products/ATContentTypes/profiles/base/skins.xml M Products/ATContentTypes/profiles/default/metadata.xml M Products/ATContentTypes/setuphandlers.py M Products/ATContentTypes/tests/test_base_profile.py M Products/ATContentTypes/tests/test_installation.py

mauritsvanrees · 2016-09-21T09:55:26Z

And it's a wrap!

Handling the documentation here: plone/documentation#696

mauritsvanrees added this to the Future milestone Jan 26, 2016

mauritsvanrees added the 03 type: feature (plip) label Jan 26, 2016

mauritsvanrees added a commit to plone/plone.app.upgrade that referenced this issue Jan 26, 2016

Started getting rid of QI.

cb2855e

plone/Products.CMFPlone#1340

mauritsvanrees added a commit to plone/Products.CMFQuickInstallerTool that referenced this issue Jan 26, 2016

These subscribers are not needed when getting rid of QI.

1a788ca

plone/Products.CMFPlone#1340

mauritsvanrees mentioned this issue Feb 1, 2016

use "default" and "uninstall" profiles collective/example.p4p5#5

Merged

thet mentioned this issue Feb 3, 2016

Added optional pre_handler and post_handler to registerProfile. zopefoundation/Products.GenericSetup#24

Merged

mauritsvanrees mentioned this issue Feb 5, 2016

Add uninstall profiles for selected core packages #1368

Closed

7 tasks

mauritsvanrees mentioned this issue Feb 7, 2016

Clear up Archetypes and ATContentTypes status on Plone 5 #1369

Closed

4 tasks

mauritsvanrees mentioned this issue Feb 10, 2016

Added uninstall profile. plone/Products.ATContentTypes#32

Merged

6 tasks

mauritsvanrees mentioned this issue Feb 29, 2016

Resource Bundle is not visible in Plone 5.0.2 collective/example.p4p5#10

Closed

ebrehault added the 21 status: confirmed label Mar 9, 2016

mauritsvanrees mentioned this issue Sep 20, 2016

Support sites without portal_quickinstaller. plone/plone.app.upgrade#86

Merged

mauritsvanrees modified the milestones: Plone 5.1, Future Sep 20, 2016

mauritsvanrees mentioned this issue Sep 20, 2016

Document QI deprecation in 5.1 upgrade guide. PLIP 1340. plone/documentation#696

Merged

This was referenced Sep 20, 2016

Idea: check dependency before uninstalling #1773

Closed

Idea: unmark default profile in event when applying uninstall profile #1774

Closed

PLIP: Remove portal_quickinstaller in Plone 6.0 #1775

Closed

mauritsvanrees closed this as completed Sep 21, 2016

mauritsvanrees mentioned this issue Sep 23, 2016

plone.app.upgrade: remove old upgrade code? #1778

Closed

pyup-vuln-bot mentioned this issue Dec 27, 2016

Changelog products.cmfplone version 5.1b1 pyupio/safety-db#2148

Merged

This was referenced Oct 5, 2017

[Plone 5.1] Warning This product cannot be uninstalled! #2167

Closed

Plone 5.1: inconsistent add-on control panel #2166

Closed

buchi mentioned this issue Mar 17, 2020

Plone 5.2 and Python 3 support 4teamwork/ftw.upgrade#197

Merged

PLIP: Get rid of portal_quickinstaller #1340

PLIP: Get rid of portal_quickinstaller #1340

mauritsvanrees commented Jan 26, 2016 •

edited by hvelarde

mauritsvanrees commented Jan 26, 2016

hvelarde commented Jan 26, 2016

keul commented Jan 26, 2016

mauritsvanrees commented Jan 26, 2016

keul commented Jan 26, 2016

hvelarde commented Jan 28, 2016

mauritsvanrees commented Jan 28, 2016

mauritsvanrees commented Jan 29, 2016

gforcada commented Jan 30, 2016

mauritsvanrees commented Jan 30, 2016

ebrehault commented Feb 2, 2016

mauritsvanrees commented Feb 5, 2016

frapell commented Feb 8, 2016

mauritsvanrees commented Feb 8, 2016

mauritsvanrees commented Feb 9, 2016

hvelarde commented Mar 1, 2016

jensens commented Sep 20, 2016 •

edited by mingtak

jensens commented Sep 20, 2016

mauritsvanrees commented Sep 20, 2016

mauritsvanrees commented Sep 20, 2016

mauritsvanrees commented Sep 20, 2016 •

edited

mauritsvanrees commented Sep 20, 2016

mauritsvanrees commented Sep 21, 2016

mauritsvanrees commented Sep 21, 2016

mauritsvanrees commented Sep 21, 2016

PLIP: Get rid of portal_quickinstaller #1340

PLIP: Get rid of portal_quickinstaller #1340

Comments

mauritsvanrees commented Jan 26, 2016 • edited by hvelarde

Proposer : Maurits van Rees

Seconder : @hvelarde

Abstract

Motivation

Assumptions

Proposal & Implementation

Deliverables

Risks

Participants

mauritsvanrees commented Jan 26, 2016

hvelarde commented Jan 26, 2016

keul commented Jan 26, 2016

mauritsvanrees commented Jan 26, 2016

keul commented Jan 26, 2016

hvelarde commented Jan 28, 2016

mauritsvanrees commented Jan 28, 2016

mauritsvanrees commented Jan 29, 2016

gforcada commented Jan 30, 2016

mauritsvanrees commented Jan 30, 2016

ebrehault commented Feb 2, 2016

mauritsvanrees commented Feb 5, 2016

frapell commented Feb 8, 2016

mauritsvanrees commented Feb 8, 2016

mauritsvanrees commented Feb 9, 2016

hvelarde commented Mar 1, 2016

jensens commented Sep 20, 2016 • edited by mingtak

jensens commented Sep 20, 2016

mauritsvanrees commented Sep 20, 2016

mauritsvanrees commented Sep 20, 2016

mauritsvanrees commented Sep 20, 2016 • edited

mauritsvanrees commented Sep 20, 2016

mauritsvanrees commented Sep 21, 2016

mauritsvanrees commented Sep 21, 2016

mauritsvanrees commented Sep 21, 2016

mauritsvanrees commented Jan 26, 2016 •

edited by hvelarde

jensens commented Sep 20, 2016 •

edited by mingtak

mauritsvanrees commented Sep 20, 2016 •

edited